[AETHER-514] Fix the previous patch (PR #100) #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesmcchan
approved these changes
Oct 19, 2020
|
The author of this PR, pierventre, is not an activated member of this organization on Codecov. |
|
Previous meaning PR #100? |
Yi-Tseng
approved these changes
Oct 19, 2020
|
Could you include PR #100 in the title? Makes it easier to cross reference later. |
In the previous patch (PR #100), a "break" was missed when the code has been ported from ONOS. Additionally, makes a further optimization: does not send hashed and next_vlan flows.
pierventre
changed the title
pierventre
changed the title
pierventre
changed the title
pierventre
force-pushed
the
fix-fix-modify
branch
from
9c2c666 to
98dd9c5
Compare
|
retest this please, Jenkins failed because of #98 |
|
anything else from my side ? Can we merge ? |
bocon13
pushed a commit
that referenced
this pull request
Dec 7, 2020
* [AETHER-514] Fix the previous patch (PR #100) In the previous patch (PR #100), a "break" was missed when the code has been ported from ONOS. Additionally, makes a further optimization: does not send hashed and next_vlan flows. * Updates ONOS deps and re-add "fail" instruction that was wrongly removed.
bocon13
pushed a commit
that referenced
this pull request
Dec 7, 2020
* [AETHER-514] Fix the previous patch (PR #100) In the previous patch (PR #100), a "break" was missed when the code has been ported from ONOS. Additionally, makes a further optimization: does not send hashed and next_vlan flows. * Updates ONOS deps and re-add "fail" instruction that was wrongly removed.
bocon13
pushed a commit
that referenced
this pull request
Dec 8, 2020
* [AETHER-514] Fix the previous patch (PR #100) In the previous patch (PR #100), a "break" was missed when the code has been ported from ONOS. Additionally, makes a further optimization: does not send hashed and next_vlan flows. * Updates ONOS deps and re-add "fail" instruction that was wrongly removed.
bocon13
pushed a commit
that referenced
this pull request
Dec 8, 2020
* [AETHER-514] Fix the previous patch (PR #100) In the previous patch (PR #100), a "break" was missed when the code has been ported from ONOS. Additionally, makes a further optimization: does not send hashed and next_vlan flows. * Updates ONOS deps and re-add "fail" instruction that was wrongly removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous patch, a "break" was missed when the code has been ported from ONOS.
Additionally, makes a further optimization: does not send hashed and next_vlan flows.