Binary_sv2 refactor #1463
Closed
Binary_sv2 refactor #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there's no point in having two directories named binary_sv2 anymore
no point in keeping this anymore
the only strict technical requirement for having a separate crate is derive_codec_sv2, which is dedicated to macro derivation but as we are unifying the `binary_sv2` crate, there's no reason to keep a separate `binary_codec_sv2` and this commit is meant to merge its `codec` and `datatypes` modules into the root `binary_sv2` crate this commit is still a WIP... I was able to get all the tests passing inside `binary_sv2` but things still break outside of it @Shourya742 please complete this commit, amending to it when you are able to finish the migration
|
Closing this PR as it is not a current priority. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of: #1387
closes: #1462