Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add coinbase_output_max_additional_sigops to SRI #1456

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GitGab19
Copy link
Collaborator

@GitGab19 GitGab19 commented Feb 5, 2025

This PR adds the coinbase_output_max_additional_sigops and renames CoinbaseOutputDataSize message into CoinbaseOutputConstraints.

Closes #1412
Blocked by #1457

@GitGab19 GitGab19 assigned GitGab19 and unassigned GitGab19 Feb 5, 2025
@GitGab19 GitGab19 marked this pull request as draft February 5, 2025 12:31
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 18.75%. Comparing base (3d22194) to head (e1a45f2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
protocols/v2/sv2-ffi/src/lib.rs 0.00% 9 Missing ⚠️
protocols/v2/roles-logic-sv2/src/parsers.rs 0.00% 7 Missing ⚠️
...es-logic-sv2/src/handlers/template_distribution.rs 0.00% 3 Missing ⚠️
...s/job-declaration/src/allocate_mining_job_token.rs 0.00% 1 Missing ⚠️
...s/v2/subprotocols/template-distribution/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1456      +/-   ##
==========================================
+ Coverage   17.96%   18.75%   +0.79%     
==========================================
  Files         167      144      -23     
  Lines       11926     9707    -2219     
==========================================
- Hits         2143     1821     -322     
+ Misses       9783     7886    -1897     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <0.00%> (ø)
binary_serde_sv2-coverage 3.39% <0.00%> (-0.01%) ⬇️
binary_sv2-coverage 5.11% <0.00%> (-0.01%) ⬇️
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <0.00%> (-0.01%) ⬇️
common_messages_sv2-coverage 0.12% <0.00%> (-0.01%) ⬇️
const_sv2-coverage 0.00% <0.00%> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.27% <0.00%> (-0.01%) ⬇️
jd_client-coverage ?
jd_server-coverage ?
job_declaration_sv2-coverage 0.00% <0.00%> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.34% <0.00%> (+0.01%) ⬆️
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.25% <0.00%> (-0.01%) ⬇️
pool_sv2-coverage ?
protocols 21.10% <0.00%> (-2.76%) ⬇️
roles 6.98% <ø> (+1.12%) ⬆️
roles_logic_sv2-coverage 8.70% <0.00%> (-0.01%) ⬇️
sv2_ffi-coverage 0.00% <0.00%> (ø)
template_distribution_sv2-coverage 0.00% <0.00%> (ø)
translator_sv2-coverage 8.74% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.31% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add coinbase_output_max_additional_sigops in job_declaration and template_distribution crates
1 participant