Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove with_serde from roles #1454

Conversation

Shourya742
Copy link
Contributor

part of: #1387

@Shourya742 Shourya742 changed the title remove with_serde from networks-helper and translator remove with_serde from roles Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.44%. Comparing base (0d00daa) to head (450204e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1454      +/-   ##
==========================================
+ Coverage   16.71%   19.44%   +2.72%     
==========================================
  Files         155      146       -9     
  Lines       11133    10244     -889     
==========================================
+ Hits         1861     1992     +131     
+ Misses       9272     8252    -1020     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.40% <ø> (ø)
binary_sv2-coverage 5.11% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (?)
buffer_sv2-coverage 25.02% <ø> (?)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.12% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (?)
framing_sv2-coverage 0.27% <ø> (ø)
jd_client-coverage 0.42% <ø> (ø)
jd_server-coverage 9.02% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.34% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.82% <ø> (ø)
noise_sv2-coverage 4.25% <ø> (ø)
protocols 23.86% <ø> (ø)
roles 3.56% <ø> (-2.87%) ⬇️
roles_logic_sv2-coverage 8.70% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage ?
utils 25.13% <ø> (?)
v1-coverage 2.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shourya742 Shourya742 force-pushed the 2025-01-31-remove-serde-feature-from-roles branch 2 times, most recently from 5f66948 to 7622143 Compare February 6, 2025 14:00
@Shourya742 Shourya742 force-pushed the 2025-01-31-remove-serde-feature-from-roles branch from 7622143 to 450204e Compare February 6, 2025 14:10
@plebhash plebhash merged commit 1370768 into stratum-mining:main Feb 6, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants