Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup async_std from network_helpers_sv2 #1433

Merged

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented Feb 1, 2025

close #1402

as described in #1402 (comment)

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.71%. Comparing base (3d22194) to head (0d00daa).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1433      +/-   ##
==========================================
- Coverage   17.96%   16.71%   -1.26%     
==========================================
  Files         167      155      -12     
  Lines       11926    11133     -793     
==========================================
- Hits         2143     1861     -282     
+ Misses       9783     9272     -511     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.40% <ø> (ø)
binary_sv2-coverage 5.11% <ø> (ø)
bip32_derivation-coverage ?
buffer_sv2-coverage ?
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.12% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage ?
framing_sv2-coverage 0.27% <ø> (ø)
jd_client-coverage 0.42% <ø> (+0.03%) ⬆️
jd_server-coverage 9.02% <ø> (+1.22%) ⬆️
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.34% <ø> (+0.01%) ⬆️
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.82% <ø> (+0.11%) ⬆️
noise_sv2-coverage 4.25% <ø> (ø)
pool_sv2-coverage ?
protocols 23.86% <ø> (ø)
roles 6.43% <ø> (+0.58%) ⬆️
roles_logic_sv2-coverage 8.70% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.53% <ø> (+0.78%) ⬆️
utils ?
v1-coverage 2.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

plebhash added a commit to plebhash/stratum that referenced this pull request Feb 1, 2025
plebhash added a commit to plebhash/stratum that referenced this pull request Feb 1, 2025
@plebhash plebhash force-pushed the network_helpers_async_std_cleanup branch from 9588fc2 to 824f85d Compare February 1, 2025 17:27
Copy link
Contributor

@Shourya742 Shourya742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Few nits.

roles/tarpaulin.toml Outdated Show resolved Hide resolved
roles/test-utils/mining-device/Cargo.toml Show resolved Hide resolved
plebhash added a commit to plebhash/stratum that referenced this pull request Feb 2, 2025
@plebhash plebhash force-pushed the network_helpers_async_std_cleanup branch from 824f85d to 70afc2e Compare February 2, 2025 17:43
@plebhash plebhash force-pushed the network_helpers_async_std_cleanup branch from 70afc2e to 196dc8c Compare February 4, 2025 13:00
@plebhash plebhash force-pushed the network_helpers_async_std_cleanup branch from 196dc8c to 0d00daa Compare February 4, 2025 13:02
roles/jd-client/Cargo.toml Show resolved Hide resolved
roles/jd-server/Cargo.toml Show resolved Hide resolved
@GitGab19 GitGab19 merged commit b413446 into stratum-mining:main Feb 6, 2025
32 checks passed
@plebhash plebhash deleted the network_helpers_async_std_cleanup branch February 6, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove async_std support
3 participants