run MG tests from new repo #1428
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1428 +/- ##
==========================================
+ Coverage 19.34% 19.99% +0.64%
==========================================
Files 144 137 -7
Lines 10963 10608 -355
==========================================
Hits 2121 2121
+ Misses 8842 8487 -355
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
plebhash
force-pushed
the
mg-tests-from-new-repo
branch
4 times, most recently
from
9094877 to
7cf0cec
Compare
| @@ -9,7 +9,7 @@ | |||
| "frame_builders": [ | |||
| { | |||
| "type": "automatic", | |||
| "message_id": "test/message-generator/messages/common_messages.json::setup_connection_job_declarator_with_no_async_flag" | |||
| "message_id": "../../test/message-generator/messages/common_messages.json::setup_connection_job_declarator_with_no_async_flag" | |||
There was a problem hiding this comment.
Why we need to change the relative path... to me it looks like we are still doing the same stuff, only extra step added is cloning the message generator.
There was a problem hiding this comment.
I understand the confusion, but unfortunately there's no easy answer for this.
it all started from the fact that most tests launch roles via cargo llvm-cov, which:
- has no proper documentation on why or how it's used
- breaks the paths when we use MG from the new repo
the best solution I could come up with was:
- replace
cargo llvm-covwithcargo run - adjust some relative paths on the JSON files
that allowed all tests to continue their execution in the same way as before
plebhash
force-pushed
the
mg-tests-from-new-repo
branch
3 times, most recently
from
6f91825 to
956fd31
Compare
that's a good catch, thanks for pointing it out I rebased the new repo to make sure this file is not removed from the git history there: also rebasing here to make sure we delete it from this repo |
plebhash
force-pushed
the
mg-tests-from-new-repo
branch
from
956fd31 to
839241b
Compare
part of #1387, more specifically #1387 (comment)
most adaptations consisted of:
llvm-covwas completely removednote: during #1298 we forgot to delete one MG test, so I'm doing it here