Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key-utils: make it no_std with a std default feature #1398

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Georges760
Copy link
Contributor

because a new std feature is intriduced, the Semver MINOR should be bumped

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 17.96%. Comparing base (3d22194) to head (010279d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
utils/key-utils/src/lib.rs 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1398      +/-   ##
==========================================
- Coverage   17.96%   17.96%   -0.01%     
==========================================
  Files         167      167              
  Lines       11926    11930       +4     
==========================================
  Hits         2143     2143              
- Misses       9783     9787       +4     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.40% <ø> (ø)
binary_sv2-coverage 5.11% <ø> (ø)
bip32_derivation-coverage 0.00% <0.00%> (ø)
buffer_sv2-coverage 24.88% <0.00%> (-0.15%) ⬇️
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.12% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <0.00%> (ø)
framing_sv2-coverage 0.27% <ø> (ø)
jd_client-coverage 0.38% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.38% <11.11%> (-0.01%) ⬇️
mining-coverage 2.32% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.25% <ø> (ø)
pool_sv2-coverage 2.04% <ø> (ø)
protocols 23.86% <ø> (ø)
roles 5.85% <ø> (ø)
roles_logic_sv2-coverage 8.70% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 8.74% <ø> (ø)
utils 25.04% <11.11%> (-0.09%) ⬇️
v1-coverage 2.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@plebhash plebhash requested a review from Shourya742 January 24, 2025 22:25
@Georges760 Georges760 force-pushed the key-utils-no-std branch 2 times, most recently from e3dcf54 to 14e4d95 Compare February 3, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant