Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove benches execution from CI #1357

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

GitGab19
Copy link
Collaborator

@GitGab19 GitGab19 commented Jan 17, 2025

This PR removes the benches execution from our CI.

It's been two days I noticed we are getting those actions failed, with the same error reported in this recent run: https://github.com/stratum-mining/stratum/actions/runs/12828449560/job/35772517584

I don't know how many times I had to open PRs to fix stuff regarding benches during last months, and given that those benches are not complete at all, it doesn't make sense to have them as a requirement on our CI.

Maybe in the future we can improve and reintroduce them again.

@GitGab19 GitGab19 added the ci/cd CI/CD label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.09%. Comparing base (31433ab) to head (2f219be).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1357   +/-   ##
=======================================
  Coverage   19.09%   19.09%           
=======================================
  Files         166      166           
  Lines       11062    11062           
=======================================
  Hits         2112     2112           
  Misses       8950     8950           
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.55% <ø> (ø)
binary_sv2-coverage 5.34% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.28% <ø> (ø)
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.44% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.44% <ø> (ø)
pool_sv2-coverage 2.05% <ø> (ø)
protocols 24.57% <ø> (ø)
roles 6.55% <ø> (ø)
roles_logic_sv2-coverage 7.93% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GitGab19 GitGab19 marked this pull request as draft January 17, 2025 12:15
@GitGab19 GitGab19 force-pushed the fix-benchmarks-ci branch 2 times, most recently from 2a0a74a to 0e45821 Compare January 21, 2025 18:24
@GitGab19 GitGab19 changed the title Remove fixed version for valgrind in benchmarks workflows Remove benches execution from CI Jan 21, 2025
@GitGab19 GitGab19 marked this pull request as ready for review January 21, 2025 18:28
Copy link
Contributor

@Shourya742 Shourya742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@plebhash plebhash merged commit 7be7d5e into stratum-mining:main Jan 21, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants