Bye Bye binary-sv2 serde #1347
Closed
Bye Bye binary-sv2 serde #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencher Report
|
| Branch | 2025-01-14-remove-serde-dependency |
| Testbed | sv2 |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result 1e3 x estimated cycles (Result Δ%) | Upper Boundary 1e3 x estimated cycles (Limit %) | Instructions | Benchmark Result instructions (Result Δ%) | Upper Boundary instructions (Limit %) | L1 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | L2 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | RAM Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot 🚷 view threshold | 2.16 (+2.23%) | 2.24 (96.57%) | 📈 view plot 🚷 view threshold | 473.00 (-0.14%) | 490.49 (96.43%) | 📈 view plot 🚷 view threshold | 733.00 (-0.41%) | 758.91 (96.59%) | 📈 view plot 🚷 view threshold | 6.00 (+16.72%) | 11.61 (51.69%) | 📈 view plot 🚷 view threshold | 40.00 (+3.39%) | 41.79 (95.72%) |
| client_sv2_handle_message_mining | 📈 view plot 🚷 view threshold | 8.32 (+1.10%) | 8.40 (98.99%) | 📈 view plot 🚷 view threshold | 2,137.00 | 📈 view plot 🚷 view threshold | 3,153.00 (-0.18%) | 3,167.41 (99.55%) | 📈 view plot 🚷 view threshold | 39.00 (+9.45%) | 41.60 (93.75%) | 📈 view plot 🚷 view threshold | 142.00 (+1.62%) | 144.63 (98.18%) | |
| client_sv2_mining_message_submit_standard | 📈 view plot 🚷 view threshold | 6.38 (+1.26%) | 6.45 (98.93%) | 📈 view plot 🚷 view threshold | 1,750.00 (-0.04%) | 1,767.49 (99.01%) | 📈 view plot 🚷 view threshold | 2,548.00 (-0.15%) | 2,575.34 (98.94%) | 📈 view plot 🚷 view threshold | 18.00 (+4.87%) | 24.02 (74.95%) | 📈 view plot 🚷 view threshold | 107.00 (+2.16%) | 108.86 (98.29%) |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot 🚷 view threshold | 14.83 (+0.70%) | 14.94 (99.27%) | 📈 view plot 🚷 view threshold | 4,694.00 (-0.01%) | 4,711.49 (99.63%) | 📈 view plot 🚷 view threshold | 6,750.00 (-0.08%) | 6,786.69 (99.46%) | 📈 view plot 🚷 view threshold | 48.00 (+4.60%) | 63.31 (75.81%) | 📈 view plot 🚷 view threshold | 224.00 (+1.27%) | 226.20 (99.03%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot 🚷 view threshold | 27.82 (+0.78%) | 28.07 (99.12%) | 📈 view plot 🚷 view threshold | 10,645.00 (+0.35%) | 10,700.14 (99.48%) | 📈 view plot 🚷 view threshold | 15,502.00 (+0.39%) | 15,596.62 (99.39%) | 📈 view plot 🚷 view threshold | 91.00 (+8.43%) | 99.35 (91.59%) | 📈 view plot 🚷 view threshold | 339.00 (+1.01%) | 343.30 (98.75%) |
| client_sv2_open_channel | 📈 view plot 🚷 view threshold | 4.51 (+2.49%) | 4.59 (98.37%) | 📈 view plot 🚷 view threshold | 1,461.00 (-0.05%) | 1,478.49 (98.82%) | 📈 view plot 🚷 view threshold | 2,155.00 (-0.26%) | 2,184.67 (98.64%) | 📈 view plot 🚷 view threshold | 10.00 (+21.44%) | 14.00 (71.44%) | 📈 view plot 🚷 view threshold | 66.00 (+4.83%) | 67.97 (97.10%) |
| client_sv2_open_channel_serialize | 📈 view plot 🚷 view threshold | 14.09 (+0.51%) | 14.20 (99.21%) | 📈 view plot 🚷 view threshold | 5,064.00 (-0.01%) | 5,081.49 (99.66%) | 📈 view plot 🚷 view threshold | 7,322.00 (-0.06%) | 7,352.71 (99.58%) | 📈 view plot 🚷 view threshold | 38.00 (+3.40%) | 48.32 (78.64%) | 📈 view plot 🚷 view threshold | 188.00 (+1.06%) | 190.91 (98.48%) |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot 🚷 view threshold | 22.89 (+0.79%) | 23.08 (99.19%) | 📈 view plot 🚷 view threshold | 8,040.00 (+0.09%) | 8,057.61 (99.78%) | 📈 view plot 🚷 view threshold | 11,687.00 (+0.02%) | 11,713.49 (99.77%) | 📈 view plot 🚷 view threshold | 85.00 (+11.92%) | 90.08 (94.36%) | 📈 view plot 🚷 view threshold | 308.00 (+1.25%) | 312.97 (98.41%) |
| client_sv2_setup_connection | 📈 view plot 🚷 view threshold | 4.75 (+1.11%) | 4.79 (98.97%) | 📈 view plot 🚷 view threshold | 1,502.00 (-0.04%) | 1,519.49 (98.85%) | 📈 view plot 🚷 view threshold | 2,275.00 (-0.16%) | 2,300.85 (98.88%) | 📈 view plot 🚷 view threshold | 11.00 (+16.36%) | 15.26 (72.07%) | 📈 view plot 🚷 view threshold | 69.00 (+2.03%) | 70.21 (98.27%) |
| client_sv2_setup_connection_serialize | 📈 view plot 🚷 view threshold | 16.24 (+0.53%) | 16.33 (99.46%) | 📈 view plot 🚷 view threshold | 5,963.00 (-0.01%) | 5,980.49 (99.71%) | 📈 view plot 🚷 view threshold | 8,654.00 (-0.11%) | 8,692.67 (99.56%) | 📈 view plot 🚷 view threshold | 48.00 (+17.54%) | 56.45 (85.03%) | 📈 view plot 🚷 view threshold | 210.00 (+0.82%) | 212.24 (98.95%) |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot 🚷 view threshold | 35.79 (+0.50%) | 35.96 (99.51%) | 📈 view plot 🚷 view threshold | 14,888.00 (+0.13%) | 14,920.01 (99.79%) | 📈 view plot 🚷 view threshold | 21,866.00 (+0.10%) | 21,919.50 (99.76%) | 📈 view plot 🚷 view threshold | 110.00 (+16.00%) | 120.36 (91.40%) | 📈 view plot 🚷 view threshold | 382.00 (+0.62%) | 385.80 (99.01%) |
|
| Branch | 2025-01-14-remove-serde-dependency |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| client-submit-serialize | 📈 view plot 🚷 view threshold | 6,638.20 (+1.15%) | 6,999.79 (94.83%) |
| client-submit-serialize-deserialize | 📈 view plot 🚷 view threshold | 7,446.90 (+0.46%) | 7,874.11 (94.57%) |
| client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 8,060.00 (-0.46%) | 9,550.67 (84.39%) |
| client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 874.24 (+0.52%) | 951.67 (91.86%) |
| client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | 📈 view plot 🚷 view threshold | 670.55 (-1.11%) | 728.80 (92.01%) |
| client-sv1-authorize-serialize/client-sv1-authorize-serialize | 📈 view plot 🚷 view threshold | 250.49 (-0.38%) | 281.61 (88.95%) |
| client-sv1-get-authorize/client-sv1-get-authorize | 📈 view plot 🚷 view threshold | 156.22 (-1.21%) | 170.14 (91.82%) |
| client-sv1-get-submit | 📈 view plot 🚷 view threshold | 6,418.90 (+1.19%) | 6,766.40 (94.86%) |
| client-sv1-get-subscribe/client-sv1-get-subscribe | 📈 view plot 🚷 view threshold | 276.81 (-4.01%) | 382.01 (72.46%) |
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 734.37 (+0.84%) | 781.85 (93.93%) |
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | 📈 view plot 🚷 view threshold | 599.17 (+0.98%) | 643.14 (93.16%) |
| client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | 📈 view plot 🚷 view threshold | 202.30 (-2.19%) | 229.38 (88.20%) |
|
| Branch | 2025-01-14-remove-serde-dependency |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result 1e3 x estimated cycles (Result Δ%) | Upper Boundary 1e3 x estimated cycles (Limit %) | Instructions | Benchmark Result 1e3 x instructions (Result Δ%) | Upper Boundary 1e3 x instructions (Limit %) | L1 Accesses | Benchmark Result 1e3 x accesses (Result Δ%) | Upper Boundary 1e3 x accesses (Limit %) | L2 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | RAM Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | 📈 view plot 🚷 view threshold | 8.42 (-0.44%) | 8.67 (97.06%) | 📈 view plot 🚷 view threshold | 3.69 (-0.92%) | 3.86 (95.54%) | 📈 view plot 🚷 view threshold | 5.16 (-1.04%) | 5.45 (94.69%) | 📈 view plot 🚷 view threshold | 8.00 (-6.14%) | 16.42 (48.71%) | 📈 view plot 🚷 view threshold | 92.00 (+0.61%) | 96.81 (95.03%) |
| get_submit | 📈 view plot 🚷 view threshold | 95.27 (-0.09%) | 95.61 (99.64%) | 📈 view plot 🚷 view threshold | 59.35 (-0.09%) | 59.71 (99.39%) | 📈 view plot 🚷 view threshold | 85.22 (-0.10%) | 85.82 (99.30%) | 📈 view plot 🚷 view threshold | 50.00 (+11.27%) | 60.54 (82.59%) | 📈 view plot 🚷 view threshold | 280.00 (-0.27%) | 291.87 (95.93%) |
| get_subscribe | 📈 view plot 🚷 view threshold | 7.91 (-0.98%) | 8.23 (96.17%) | 📈 view plot 🚷 view threshold | 2.77 (-1.63%) | 2.94 (93.98%) | 📈 view plot 🚷 view threshold | 3.84 (-1.95%) | 4.14 (92.81%) | 📈 view plot 🚷 view threshold | 16.00 (+26.73%) | 20.95 (76.39%) | 📈 view plot 🚷 view threshold | 114.00 (-0.46%) | 117.92 (96.67%) |
| serialize_authorize | 📈 view plot 🚷 view threshold | 12.15 (-0.90%) | 12.51 (97.13%) | 📈 view plot 🚷 view threshold | 5.27 (-0.58%) | 5.43 (97.05%) | 📈 view plot 🚷 view threshold | 7.33 (-0.68%) | 7.60 (96.37%) | 📈 view plot 🚷 view threshold | 12.00 (+16.36%) | 18.95 (63.32%) | 📈 view plot 🚷 view threshold | 136.00 (-1.42%) | 143.33 (94.89%) |
| serialize_deserialize_authorize | 📈 view plot 🚷 view threshold | 24.60 (-0.47%) | 25.19 (97.66%) | 📈 view plot 🚷 view threshold | 9.84 (-0.18%) | 10.01 (98.28%) | 📈 view plot 🚷 view threshold | 13.88 (-0.20%) | 14.17 (97.91%) | 📈 view plot 🚷 view threshold | 37.00 (+2.84%) | 45.97 (80.48%) | 📈 view plot 🚷 view threshold | 301.00 (-0.86%) | 313.67 (95.96%) |
| serialize_deserialize_handle_authorize | 📈 view plot 🚷 view threshold | 30.15 (-0.56%) | 30.73 (98.12%) | 📈 view plot 🚷 view threshold | 12.02 (-0.21%) | 12.19 (98.67%) | 📈 view plot 🚷 view threshold | 17.00 (-0.30%) | 17.29 (98.32%) | 📈 view plot 🚷 view threshold | 60.00 (+7.37%) | 67.53 (88.85%) | 📈 view plot 🚷 view threshold | 367.00 (-1.07%) | 379.52 (96.70%) |
| serialize_deserialize_handle_submit | 📈 view plot 🚷 view threshold | 126.16 (-0.23%) | 126.79 (99.50%) | 📈 view plot 🚷 view threshold | 73.21 (-0.05%) | 73.53 (99.56%) | 📈 view plot 🚷 view threshold | 104.92 (-0.07%) | 105.51 (99.44%) | 📈 view plot 🚷 view threshold | 111.00 (+3.87%) | 125.89 (88.17%) | 📈 view plot 🚷 view threshold | 591.00 (-1.13%) | 610.75 (96.77%) |
| serialize_deserialize_handle_subscribe | 📈 view plot 🚷 view threshold | 27.79 (-0.43%) | 28.38 (97.90%) | 📈 view plot 🚷 view threshold | 9.59 (-0.39%) | 9.76 (98.29%) | 📈 view plot 🚷 view threshold | 13.54 (-0.54%) | 13.84 (97.84%) | 📈 view plot 🚷 view threshold | 71.00 (+9.81%) | 78.21 (90.78%) | 📈 view plot 🚷 view threshold | 397.00 (-0.56%) | 409.79 (96.88%) |
| serialize_deserialize_submit | 📈 view plot 🚷 view threshold | 115.10 (-0.12%) | 115.72 (99.47%) | 📈 view plot 🚷 view threshold | 68.06 (+0.01%) | 68.42 (99.47%) | 📈 view plot 🚷 view threshold | 97.65 (+0.01%) | 98.29 (99.35%) | 📈 view plot 🚷 view threshold | 67.00 (+1.91%) | 87.80 (76.31%) | 📈 view plot 🚷 view threshold | 489.00 (-0.90%) | 505.38 (96.76%) |
| serialize_deserialize_subscribe | 📈 view plot 🚷 view threshold | 23.16 (-0.68%) | 23.82 (97.25%) | 📈 view plot 🚷 view threshold | 8.14 (-0.50%) | 8.32 (97.93%) | 📈 view plot 🚷 view threshold | 11.45 (-0.56%) | 11.75 (97.51%) | 📈 view plot 🚷 view threshold | 39.00 (-0.24%) | 51.24 (76.11%) | 📈 view plot 🚷 view threshold | 329.00 (-0.80%) | 342.46 (96.07%) |
| serialize_submit | 📈 view plot 🚷 view threshold | 99.65 (-0.14%) | 100.09 (99.56%) | 📈 view plot 🚷 view threshold | 61.41 (-0.07%) | 61.73 (99.47%) | 📈 view plot 🚷 view threshold | 88.08 (-0.08%) | 88.65 (99.36%) | 📈 view plot 🚷 view threshold | 53.00 (+9.67%) | 67.21 (78.86%) | 📈 view plot 🚷 view threshold | 323.00 (-0.74%) | 337.62 (95.67%) |
| serialize_subscribe | 📈 view plot 🚷 view threshold | 11.36 (-0.35%) | 11.60 (97.95%) | 📈 view plot 🚷 view threshold | 4.12 (-1.01%) | 4.28 (96.16%) | 📈 view plot 🚷 view threshold | 5.70 (-1.29%) | 6.00 (95.12%) | 📈 view plot 🚷 view threshold | 18.00 (+28.00%) | 24.48 (73.52%) | 📈 view plot 🚷 view threshold | 159.00 (+0.28%) | 164.64 (96.57%) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1347 +/- ##
==========================================
+ Coverage 16.90% 24.63% +7.73%
==========================================
Files 164 91 -73
Lines 10956 6511 -4445
==========================================
- Hits 1852 1604 -248
+ Misses 9104 4907 -4197
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@Shourya742 Should we close this and reopen in MG repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effort to replace the binary-sv2 serde crate with a custom JSON implementation, as defined in this PR: #1323.