-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the way that signatures are collected #283
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,12 @@ | |||
namespace Stratis.FederatedPeg.Features.FederationGateway.Interfaces | |||
{ | |||
public interface ISignatureProvider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please describe the purpose and behaviour of this class in details, its clear it provides signatures but from who and how are the keys provided?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The keys are provided by the API call that activates federation. The purpose of the class is in the associated issue. I will add the detail to the class.
@quantumagi please describe again the intention behind this change. One thing I don't get here is why do you need to pass signature information between the main and sidechain nodes (the two nodes connect to each other via api), signature material is passed around int he p2p payloads. |
@dangershony, let's keep this PR on hold until after the release. There is no intention to pass signatures between main and sidechain nodes. The plan is to replace the P2P calls with API calls (or wait for the P2P results) to support the following simplified synchronous workflow: e.g. a new
This way there is no need to reserve UTXO's in the current way. We simply build, sign and broadcast in a single step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locking so it doesn't go in by mistake.
See #281