Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Update sendToCCBill() to avoid using dynamic order pr… #55

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

MaximilianoRicoTabo
Copy link

…operties

All Submissions:

Changes proposed in this Pull Request:

  • Get rid of initial payment from $order in favor of the subtotal taken from level retrieved through $order->getMembershipLevelAtCheckout();
  • Use this level to get the info to handle recurring payments
  • Get rid of Billing Period in favor of $level above and cycle_period attr
  • Refactor $recurring_period to simplify

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@MaximilianoRicoTabo MaximilianoRicoTabo force-pushed the enhancement/avoid-dynamic-properties branch from ab863e8 to ea3230e Compare January 28, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant