Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing membership report "vs cancel" and "vs expiration", add table below chart #3260

Merged

Conversation

dparker1005
Copy link
Member

@dparker1005 dparker1005 commented Jan 17, 2025

All Submissions:

Changes proposed in this Pull Request:

The "Signups vs. Cancellations" and "Signups vs. Expirations" reports have been broken since v3.0. This PR:

  1. Fixes those reports (See abstraction in function drawVisualization(). The issue was JS errors caused by [' and <?php being on new lines in the deleted code)
  2. Removes unnecessary if ( $type === 'signup_v_cancel' || $type === 'signup_v_expiration' || $type === 'signup_v_all' ) { conditions that always evaluate to true (resulting indentation changes is most of the diff)
  3. Adds the raw report data in a table under the chart.

Screenshot 2025-01-17 at 1 53 22 PM

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@kimcoleman kimcoleman removed the request for review from andrewlimaza January 21, 2025 20:04
@kimcoleman kimcoleman merged commit 2679ab0 into strangerstudios:dev Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants