Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing showing activate link after installing Add On #3255

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

dparker1005
Copy link
Member

@dparker1005 dparker1005 commented Jan 15, 2025

All Submissions:

Changes proposed in this Pull Request:

Alternate to #3254

After installing an Add On via the Memberships > Add Ons page, we try to find an "activate" link to show the user so that they can immediately activate the plugin. This functionality was not working. Upon testing, I found that this may have been due to the Code Snippets having a button with the .button-primary class that confused our code in thinking that was the "activate" button.

This PR fixes the issue by specifically looking for a link with plugins.php?action=activate&plugin= to greatly increase our chances of finding the correct activation link.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant