Fix PHP fatal error if Add On check returns null #3249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
We saw the following fatal error on the plugins/updates page if the site fails to retrieve the list of Add Ons:
An error of type E_ERROR was caused in line 59 of the file /.../wp-content/plugins/paid-memberships-pro/includes/addons.php. Error message: Uncaught TypeError: array_column(): Argument #1 ($array) must be of type array, null given in /.../wp-content/plugins/paid-memberships-pro/includes/addons.php:59 Stack trace: #0 /.../wp-content/plugins/paid-memberships-pro/includes/addons.php(59): array_column() #1 /.../wp-content/plugins/paid-memberships-pro/includes/addons.php(265): pmpro_getAddons() #2 /.../wp-includes/class-wp-hook.php(326): pmpro_update_plugins_filter() #3 ......
This PR checks whether
$addons
is empty to avoid passingnull
intoarray_column()
.Other information:
Changelog entry