Passing the checkout level to hooks during checkout flow instead of caching #3246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
In 3.0, we added caching to
pmpro_getLevelAtCheckout()
to speed up Add Ons retrieving checkout level information. However, this caching caused issues in edge cases where incorrect level data was retrieved early on page loads.This PR passes the actual checkout level object to relevant hooks at checkout in lieu of caching the function. This also has the benefit of simplifying Add On code by directly passing checkout levels into functions instead of retrieving them with a function call.
Other information:
Changelog entry