Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNW-Vite: Fix typos #30437

Merged
merged 1 commit into from
Feb 1, 2025
Merged

RNW-Vite: Fix typos #30437

merged 1 commit into from
Feb 1, 2025

Conversation

shilman
Copy link
Member

@shilman shilman commented Feb 1, 2025

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

This PR addresses minor syntax corrections in the React Native Web Vite documentation, focusing on TypeScript configuration examples.

  • Fixed missing commas in array type definitions within pluginBabelOptions configuration in /docs/get-started/frameworks/react-native-web-vite.mdx
  • Corrected trailing comma syntax in code examples
  • Improved TypeScript configuration accuracy without changing functionality

@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch ci:docs Run the CI jobs for documentation checks only. react-native-web labels Feb 1, 2025
@shilman shilman merged commit dca5ced into next Feb 1, 2025
4 of 6 checks passed
@shilman shilman deleted the shilman/fix-rnw-vite-docs branch February 1, 2025 11:34
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@github-actions github-actions bot mentioned this pull request Feb 1, 2025
9 tasks
Copy link

nx-cloud bot commented Feb 1, 2025

View your CI Pipeline Execution ↗ for commit d79d0cb.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 48s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-01 11:38:22 UTC

@github-actions github-actions bot mentioned this pull request Feb 1, 2025
13 tasks
shilman added a commit that referenced this pull request Feb 1, 2025
RNW-Vite: Fix typos
(cherry picked from commit dca5ced)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch react-native-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant