Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:copy paste URL & bumping the Elements versions #2714

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Conversation

SB-venkatyadavilli
Copy link
Contributor

@SB-venkatyadavilli SB-venkatyadavilli commented Sep 20, 2024

Addressed

STOP-979

Description

Fixed the Extra newline added when copying URLs from documentation and bumping the Elements version

Testing

Tested on Local Env.

Screenshot

I have copied URL from here
image

Before

when I pasted this URL, It is breaking into 2 parts

image

After

Same URL pasted after the fix, It is working as expected.

image

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for stoplight-elements ready!

Name Link
🔨 Latest commit c7aa027
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements/deploys/66fa7e2837e9aa000815e0fb
😎 Deploy Preview https://deploy-preview-2714--stoplight-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for stoplight-elements-demo ready!

Name Link
🔨 Latest commit c7aa027
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements-demo/deploys/66fa7e28d43ead0008225366
😎 Deploy Preview https://deploy-preview-2714--stoplight-elements-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bhaskarsontakke
Copy link

@SB-venkatyadavilli Please add before and after working screenshot/video as artifacts. Thanks

Copy link

@prafullaAtSB prafullaAtSB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the description on the solution in jira ticket.
Changes looks ok to go ahead.

@SB-venkatyadavilli SB-venkatyadavilli changed the title fix:copy paste URL fix:copy paste URL & bumping the Elements versions Sep 30, 2024
@SB-venkatyadavilli SB-venkatyadavilli merged commit 3f6dafe into main Sep 30, 2024
7 checks passed
@SB-venkatyadavilli SB-venkatyadavilli deleted the fix/979 branch September 30, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants