Fix eslint (#176)

stoat-dev · Feb 7, 2023 · e776ab9 · e776ab9
1 parent 5617e1b
commit e776ab9
Show file tree

Hide file tree

Showing 11 changed files with 1,279 additions and 32 deletions.
diff --git a/.idea/stoat-action.iml b/.idea/stoat-action.iml
diff --git a/action/.eslintrc.json b/action/.eslintrc.json
@@ -5,7 +5,7 @@
   "parserOptions": {
     "ecmaVersion": 9,
     "sourceType": "module",
-    "project": "./tsconfig.json"
+    "project": ["./tsconfig.json", "./tsconfig.test.json"]
   },
   "rules": {
     "prettier/prettier": "off",

diff --git a/action/jest.config.js b/action/jest.config.js
@@ -3,7 +3,7 @@ module.exports = {
   moduleFileExtensions: ['js', 'ts'],
   testMatch: ['**/*.test.ts'],
   transform: {
-    '^.+\\.ts$': 'ts-jest'
+    '^.+\\.ts$': ['ts-jest', { tsconfig: './tsconfig.test.json' }]
   },
   collectCoverage: true,
   verbose: true

diff --git a/action/tsconfig.test.json b/action/tsconfig.test.json
@@ -0,0 +1,5 @@
+{
+  "extends": "./tsconfig.json",
+  "include": ["src/**/*.ts", "src/**/*.json", "__tests__/**/*.test.ts"],
+  "exclude": ["node_modules"]
+}
diff --git a/cli/.eslintrc.json b/cli/.eslintrc.json
@@ -5,7 +5,7 @@
   "parserOptions": {
     "ecmaVersion": 9,
     "sourceType": "module",
-    "project": "./tsconfig.json"
+    "project": ["./tsconfig.json", "./tsconfig.test.json"]
   },
   "rules": {
     "prettier/prettier": "off",
@@ -51,7 +51,9 @@
     "@typescript-eslint/type-annotation-spacing": "error",
     "@typescript-eslint/unbound-method": "error",
     "no-shadow": "off",
-    "@typescript-eslint/no-shadow": "error"
+    "@typescript-eslint/no-shadow": "error",
+    "no-console": "off",
+    "github/array-foreach": "warn"
   },
   "settings": {
     "import/resolver": {

diff --git a/cli/__tests__/stoatActionHelpers.test.ts b/cli/__tests__/stoatActionHelpers.test.ts
@@ -7,20 +7,29 @@ import { addStoatActionToYaml, isOnPushOrPull } from '../src/helpers/init/config
 
 describe('Add Stoat Action to YAML', () => {
   test('add action to build job', async () => {
-    expect(addStoatActionToYaml({ name: 'build', workflowFile: path.join(__dirname, 'example.yaml') })).toEqual(
-      fs.readFileSync(path.join(__dirname, 'expected-add-build.yaml')).toString()
-    );
+    expect(
+      addStoatActionToYaml({
+        name: 'build',
+        workflowFile: path.join(__dirname, 'example.yaml')
+      })
+    ).toEqual(fs.readFileSync(path.join(__dirname, 'expected-add-build.yaml')).toString());
   });
 
   test('add action to build2 job', async () => {
-    expect(addStoatActionToYaml({ name: 'build2', workflowFile: path.join(__dirname, 'example.yaml') })).toEqual(
-      fs.readFileSync(path.join(__dirname, 'expected-add-build2.yaml')).toString()
-    );
+    expect(
+      addStoatActionToYaml({
+        name: 'build2',
+        workflowFile: path.join(__dirname, 'example.yaml')
+      })
+    ).toEqual(fs.readFileSync(path.join(__dirname, 'expected-add-build2.yaml')).toString());
   });
 
   test('add action to both build and build2 jobs', async () => {
     expect(
-      addStoatActionToYaml({ name: 'build2', workflowFile: path.join(__dirname, 'expected-add-build.yaml') })
+      addStoatActionToYaml({
+        name: 'build2',
+        workflowFile: path.join(__dirname, 'expected-add-build.yaml')
+      })
     ).toEqual(fs.readFileSync(path.join(__dirname, 'expected-add-build-and-build2.yaml')).toString());
   });
 });

diff --git a/cli/jest.config.js b/cli/jest.config.js
@@ -3,7 +3,7 @@ module.exports = {
   moduleFileExtensions: ['js', 'ts'],
   testMatch: ['**/*.test.ts'],
   transform: {
-    '^.+\\.ts$': 'ts-jest'
+    '^.+\\.ts$': ['ts-jest', { tsconfig: './tsconfig.test.json' }]
   },
   collectCoverage: true,
   verbose: true

diff --git a/cli/package.json b/cli/package.json
@@ -65,6 +65,9 @@
     "@types/node": "^18.11.13",
     "@vercel/ncc": "^0.36.0",
     "esbuild": "^0.17.4",
+    "eslint": "^8.33.0",
+    "eslint-config-prettier": "^8.6.0",
+    "eslint-plugin-github": "^4.6.0",
     "eslint-plugin-jest": "^27.2.1",
     "husky": "^8.0.3",
     "jest": "^29.3.1",

diff --git a/cli/src/helpers/versionWarningBanner.ts b/cli/src/helpers/versionWarningBanner.ts
@@ -4,7 +4,7 @@ import latestVersion from 'latest-version';
 
 import { version } from '../../package.json';
 
-export default async function () {
+export default async function main() {
   try {
     const latest = await latestVersion('stoat');
 
@@ -17,10 +17,12 @@ export default async function () {
       'Please upgrade by running: npm update -g stoat'
     ];
 
-    if (compareVersions(version, latest!) < 0) {
+    if (compareVersions(version, latest) < 0) {
       const longest = Math.max(...versionWarning.map((line) => line.length));
       console.warn(chalk.yellow('-'.repeat(longest)));
-      versionWarning.forEach((line) => console.warn(chalk.yellow(`${line}`)));
+      for (const line of versionWarning) {
+        console.warn(chalk.yellow(`${line}`));
+      }
       console.warn(chalk.yellow('-'.repeat(longest)));
       console.warn();
     }

diff --git a/cli/tsconfig.test.json b/cli/tsconfig.test.json
@@ -0,0 +1,5 @@
+{
+  "extends": "./tsconfig.json",
+  "include": ["src/**/*.ts", "src/**/*.json", "__tests__/**/*.test.ts"],
+  "exclude": ["node_modules"]
+}