Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead lock with pin above NUM_DIGITAL_PINS #2629

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Fix dead lock with pin above NUM_DIGITAL_PINS #2629

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b06ba1d
Fix dead lock with pin above NUM_DIGITAL_PINS
VitorBoss Jan 13, 2025
8014027
fixup: only one return
fpistm Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions cores/arduino/wiring_digital.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,17 +78,28 @@ void pinMode(uint32_t ulPin, uint32_t ulMode)

void digitalWrite(uint32_t ulPin, uint32_t ulVal)
{
digitalWriteFast(digitalPinToPinName(ulPin), ulVal);
PinName p = digitalPinToPinName(ulPin);
if (p != NC) {
digitalWriteFast(p, ulVal);
}
}

int digitalRead(uint32_t ulPin)
{
return digitalReadFast(digitalPinToPinName(ulPin));
PinName p = digitalPinToPinName(ulPin);

if (p == NC) {
return 0;
}
return digitalReadFast(p);
fpistm marked this conversation as resolved.
Show resolved Hide resolved
}

void digitalToggle(uint32_t ulPin)
{
digitalToggleFast(digitalPinToPinName(ulPin));
PinName p = digitalPinToPinName(ulPin);
if (p != NC) {
digitalToggleFast(digitalPinToPinName(ulPin));
}
}

#ifdef __cplusplus
Expand Down
Loading