Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small changes for clarity #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gness1804
Copy link

This pull request proposes two small changes to the instructions for clarity:

  • For the exercise 'Reject a Promise', I added a line in the Hint section to link to the MDN documentation on Error objects, because I (and I suspect others) were confused about the reference to this in the instructions.
  • For 'An Important Rule', I reformatted the 'rule of thumb' slightly because the original version was rendering in hard-to-read dark blue on some black terminal screens.

Hopefully, these changes will make the instructions a bit easier for new users. I also included both edits in the French version for each exercise.

…r objects for clarification; also changes the formatting of the 'rule of thumb' in 'An Important Rule' to italic because the prior formatting was rendering in a hard-to-read dark blue on some black terminal screens.

changes wording to edit to directions for exercise 3 from previous commit

Modifies formatting of link in 'Reject A Promise' to flow better with the text. Also changes the formatting of the 'rule of thumb' in 'An Important Rule' to italic because the prior formatting was rendering in a hard-to-read dark blue on some black terminal screens.

Moves the MDN link from body of the assignment instructions down to the
Hint section.
@TimothyGu
Copy link
Collaborator

I'll try to review this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants