Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upper-case TaxExemptionReasonCodes ToString extension method #275

Closed
wants to merge 1 commit into from
Closed

Conversation

tipa
Copy link
Contributor

@tipa tipa commented May 28, 2024

Fixes #274

@stephanstapel
Copy link
Owner

Thanks for the pull request. I'd rather go and make the values themselves uppercase as this would be consistent with (almost) all remaining code enums in the library. Whyever they are lower case currently..
Thus I'd like to reject the pull request and will fix #274 quickly by myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TaxExemptionReasonCodes aren't upper-case
2 participants