If the ram:ID is not set for the Seller or Buyer Party, an empty tag is no longer written #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s` file have been updated to include an optional parameter for `id`. This parameters has a default values of `null`. This change allows for more flexibility when setting the buyer or seller information. (Reference: `InvoiceDescriptor.cs`) 2. In the `InvoiceDescriptor21Writer.cs` file, a condition has been added to the `else` clause in the `if` statement. Now, the `ram:ID` element will only be written if `party.ID.ID` is not null or an empty string. This change prevents writing an emtpy 'ram:id'. (Reference: `InvoiceDescriptor21Writer.cs`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SetBuyerandSetSellermethods in theInvoiceDescriptor.csfile have been updated to include an optional parameter forid. This parameters has a default values ofnull. This change allows for more flexibility when setting the buyer or seller information. (Reference:InvoiceDescriptor.cs)In the
InvoiceDescriptor21Writer.csfile, a condition has been added to theelseclause in theifstatement. Now, theram:IDelement will only be written ifparty.ID.IDis not null or an empty string. This change prevents writing an emtpy 'ram:id'. (Reference:InvoiceDescriptor21Writer.cs)