Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 compatibility #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

noamkush
Copy link

No description provided.

@stephan-hof
Copy link
Owner

Many thanks for this contribution. I'll have a look at this soon.

However there is one thing to mention.

In python3 they fixed threading.Condition, which is used by Queue from the standard library. In python3 threading.Condition is not doing busy waiting any more.
So now boost_queue and Queue are using the same locking mechanics under the hood, which means they should have the same performance characteristics in threaded applications.

So my recommendation would be to use Queue from the standard library instead of boost_queue when you use python3.

@noamkush
Copy link
Author

noamkush commented Jun 28, 2017

Well, my use case involves a time sensitive system with a high throughput queue. The boost implementation is still 15x faster on python 3.4/3.5 (haven't tested on 3.6) for non-blocking put/get.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants