-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/distributed create entity #1321
base: develop
Are you sure you want to change the base?
Conversation
Test Results 71 files + 1 71 suites +1 1m 31s ⏱️ +9s Results for commit 9533ddf. ± Comparison against base commit 3f38fd5. This pull request removes 187 and adds 45 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
dc83f2a
to
0942d7c
Compare
(missing error gestion and tests)
9dd9607
to
487d0a9
Compare
search-service/src/main/kotlin/com/egm/stellio/search/csr/model/CSRFilters.kt
Outdated
Show resolved
Hide resolved
|
||
fun getMatchingPropertiesAndRelationships( | ||
csrFilters: InternalCSRFilters | ||
): Pair<Set<ExpandedTerm>?, Set<ExpandedTerm>?> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without reading the code, the returned structure is a mystery (do you even need to separate them?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, i think so because the contextSource distinguish the "propertyNames" from the "relationshipNames" (5.2.10).
It could make sense for example if you want to have a CSR who have all the properties but only one relationship.
(I considered that if "propertyNames"(or "relationshipNames") where not provided that meant all the properties (or relationships) were distributed to the context source)
shared/src/main/kotlin/com/egm/stellio/shared/model/ExpandedEntity.kt
Outdated
Show resolved
Hide resolved
search-service/src/main/kotlin/com/egm/stellio/search/csr/model/ContextSourceRegistration.kt
Outdated
Show resolved
Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/model/ExpandedEntity.kt
Outdated
Show resolved
Hide resolved
...vice/src/main/kotlin/com/egm/stellio/search/csr/service/DistributedEntityProvisionService.kt
Outdated
Show resolved
Hide resolved
...vice/src/main/kotlin/com/egm/stellio/search/csr/service/DistributedEntityProvisionService.kt
Show resolved
Hide resolved
shared/src/main/kotlin/com/egm/stellio/shared/model/ApiExceptions.kt
Outdated
Show resolved
Hide resolved
c785fa5
to
a7699c4
Compare
Quality Gate passedIssues Measures |
Still missing :
test for EntityHandler createtest for DistributedEntityProvisionService