Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/distributed create entity #1321

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

thomasBousselin
Copy link
Contributor

@thomasBousselin thomasBousselin commented Jan 20, 2025

Still missing :

  • test for EntityHandler create
  • test for DistributedEntityProvisionService

@github-actions github-actions bot added the feature New feature or request label Jan 20, 2025
Copy link
Contributor

github-actions bot commented Jan 20, 2025

Test Results

   71 files  + 1     71 suites  +1   1m 31s ⏱️ +9s
1 160 tests +12  1 160 ✅ +12  0 💤 ±0  0 ❌ ±0 
1 199 runs  +12  1 199 ✅ +12  0 💤 ±0  0 ❌ ±0 

Results for commit 9533ddf. ± Comparison against base commit 3f38fd5.

This pull request removes 187 and adds 45 tests. Note that renamed tests count towards both.
                           …, temporalRepresentation=TEMPORAL_VALUES, withAudit=false, expectation={
                      "@id": "https://uri…
                      "@type": "@json",
                      …
                    "@value": "/A/B"
                    "@value": "/C/D"
                    "@value": 20
                    "…
                    {
                  "@type": "https://uri.etsi.org/ngsi-ld/DateTime",
…
com.egm.stellio.search.csr.model.ContextSourceRegistrationTests ‑ getAssociatedAttributes should check properties and relationship separately()
com.egm.stellio.search.csr.model.ContextSourceRegistrationTests ‑ getAssociatedAttributes should not get Attributes for non matching registrationInfo()
com.egm.stellio.search.csr.service.DistributedEntityProvisionServiceTests ‑ distributeCreateEntity should return the errors received and the remainingEntity()
com.egm.stellio.search.csr.service.DistributedEntityProvisionServiceTests ‑ distributeCreateEntityForContextSources should remove the attrs even when the csr is in error()
com.egm.stellio.search.csr.service.DistributedEntityProvisionServiceTests ‑ distributeCreateEntityForContextSources should return null if all the entity have been processed()
com.egm.stellio.search.csr.service.DistributedEntityProvisionServiceTests ‑ distributeCreateEntityForContextSources should return only non processed attributes()
com.egm.stellio.search.csr.service.DistributedEntityProvisionServiceTests ‑ distributeCreateEntityForContextSources should return received errors and successes()
com.egm.stellio.search.csr.service.DistributedEntityProvisionServiceTests ‑ postDistributedInformation should process badly formed errors()
com.egm.stellio.search.csr.service.DistributedEntityProvisionServiceTests ‑ postDistributedInformation should return a GateWayTimeOut if it receives no answer()
com.egm.stellio.search.csr.service.DistributedEntityProvisionServiceTests ‑ postDistributedInformation should return the received error()
…

♻️ This comment has been updated with latest results.

@thomasBousselin thomasBousselin force-pushed the refactor/filter-attributes-signature branch 2 times, most recently from dc83f2a to 0942d7c Compare January 20, 2025 14:45
Base automatically changed from refactor/filter-attributes-signature to develop January 20, 2025 14:56
@thomasBousselin thomasBousselin force-pushed the feature/distributed-create-entity branch from 9dd9607 to 487d0a9 Compare January 20, 2025 14:57

fun getMatchingPropertiesAndRelationships(
csrFilters: InternalCSRFilters
): Pair<Set<ExpandedTerm>?, Set<ExpandedTerm>?> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without reading the code, the returned structure is a mystery (do you even need to separate them?)

Copy link
Contributor Author

@thomasBousselin thomasBousselin Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, i think so because the contextSource distinguish the "propertyNames" from the "relationshipNames" (5.2.10).

It could make sense for example if you want to have a CSR who have all the properties but only one relationship.

(I considered that if "propertyNames"(or "relationshipNames") where not provided that meant all the properties (or relationships) were distributed to the context source)

@thomasBousselin thomasBousselin linked an issue Jan 21, 2025 that may be closed by this pull request
@thomasBousselin thomasBousselin self-assigned this Jan 21, 2025
@thomasBousselin thomasBousselin force-pushed the feature/distributed-create-entity branch from c785fa5 to a7699c4 Compare January 22, 2025 09:22
@thomasBousselin thomasBousselin marked this pull request as ready for review January 24, 2025 09:53
@thomasBousselin thomasBousselin added the csr Relates to context sources (registrations) API label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csr Relates to context sources (registrations) API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement csr for createEntity endpoint
2 participants