bug with default params to pipeline stack

stelligent · Feb 1, 2017 · 9893b82 · 9893b82
1 parent b1d9be2
commit 9893b82
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 19 deletions.
diff --git a/Makefile b/Makefile
@@ -26,7 +26,7 @@ deps:
 	glide install
 	go generate $(SRC_FILES)
 
-lint:
+lint: fmt
 	@echo "=== linting ==="
 	go vet $(SRC_FILES)
 	glide novendor | xargs -n1 golint -set_exit_status
@@ -85,7 +85,7 @@ clean:
 all: clean deps test build
 
 fmt:
-	@echo "=== cleaning ==="
+	@echo "=== formatting ==="
 	go fmt $(SRC_FILES)
 
 

diff --git a/templates/assets.go b/templates/assets.go
diff --git a/workflows/pipeline_upsert.go b/workflows/pipeline_upsert.go
@@ -60,11 +60,18 @@ func (workflow *pipelineWorkflow) pipelineUpserter(tokenProvider func(bool) stri
 		}
 		pipelineParams["GitHubUser"] = sourceRepo[0]
 		pipelineParams["GitHubRepo"] = sourceRepo[1]
-		pipelineParams["GitHubBranch"] = workflow.pipelineConfig.Source.Branch
 		pipelineParams["GitHubToken"] = tokenProvider(pipelineStack == nil)
 
-		pipelineParams["BuildType"] = workflow.pipelineConfig.Build.Type
-		pipelineParams["BuildComputeType"] = workflow.pipelineConfig.Build.ComputeType
+		if workflow.pipelineConfig.Source.Branch != "" {
+			pipelineParams["GitHubBranch"] = workflow.pipelineConfig.Source.Branch
+		}
+
+		if workflow.pipelineConfig.Build.Type != "" {
+			pipelineParams["BuildType"] = workflow.pipelineConfig.Build.Type
+		}
+		if workflow.pipelineConfig.Build.ComputeType != "" {
+			pipelineParams["BuildComputeType"] = workflow.pipelineConfig.Build.ComputeType
+		}
 
 		if workflow.pipelineConfig.Build.Image != "" {
 			pipelineParams["BuildImage"] = workflow.pipelineConfig.Build.Image