Fix --log-format parsing #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I broke it at stellar#228 It turns out that `github.com/stellar/go/support/errors.Wrapf` returns nil if the error is nil (which is different to how `errors.Errorf` behaves). I have looked at both stellar#228 and stellar#224 and this is the only instance in which we replaced `Wrapf` by `Errorf` where we don't first check the error for `nil`.
2opremio
force-pushed
the
fix-log-format-parsing
branch
from
4e8f415 to
edb3910
Compare
mollykarcher
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke it at #228
It turns out that
github.com/stellar/go/support/errors.Wrapfreturns nil if the error is nil (which is different to howerrors.Errorfbehaves).I have looked at both #228 and #224 and this is the only instance in which we replaced
WrapfbyErrorfwhere we don't first check the error fornil.