Address review feedback

stellar · Jan 22, 2025 · adb6fa0 · adb6fa0
1 parent 6b2aac1
commit adb6fa0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/cmd/stellar-rpc/internal/methods/get_events.go b/cmd/stellar-rpc/internal/methods/get_events.go
@@ -135,14 +135,12 @@ func (g *GetEventsRequest) Valid(maxLimit uint) error {
 		if g.Pagination.Limit > maxLimit {
 			return fmt.Errorf("limit must not exceed %d", maxLimit)
 		}
-	} else {
-		// Pagination not enabled
-		if g.StartLedger <= 0 {
-			return errors.New("startLedger must be positive")
-		}
-		if g.EndLedger > 0 && g.EndLedger < g.StartLedger {
-			return errors.New("startLedger must be <= endLedger")
-		}
+	}
+	if g.StartLedger <= 0 {
+		return errors.New("startLedger must be positive")
+	}
+	if g.EndLedger > 0 && g.EndLedger < g.StartLedger {
+		return errors.New("startLedger must be <= endLedger")
 	}
 
 	return nil

diff --git a/cmd/stellar-rpc/internal/methods/get_transactions.go b/cmd/stellar-rpc/internal/methods/get_transactions.go
@@ -46,7 +46,8 @@ func (req GetTransactionsRequest) isValid(maxLimit uint, ledgerRange ledgerbucke
 		if req.Pagination.Limit > maxLimit {
 			return fmt.Errorf("limit must not exceed %d", maxLimit)
 		}
-	} else if req.StartLedger < ledgerRange.FirstLedger.Sequence || req.StartLedger > ledgerRange.LastLedger.Sequence {
+	}
+	if req.StartLedger < ledgerRange.FirstLedger.Sequence || req.StartLedger > ledgerRange.LastLedger.Sequence {
 		return fmt.Errorf(
 			"start ledger must be between the oldest ledger: %d and the latest ledger: %d for this rpc instance",
 			ledgerRange.FirstLedger.Sequence,