Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional SEP-9 fields #344

Merged
merged 1 commit into from
May 1, 2024
Merged

Add additional SEP-9 fields #344

merged 1 commit into from
May 1, 2024

Conversation

Ifropc
Copy link
Contributor

@Ifropc Ifropc commented May 1, 2024

No description provided.

@Ifropc Ifropc requested a review from quietbits May 1, 2024 18:38
@@ -48,6 +53,11 @@ const FIELDS = [
label: "Address",
type: "text",
},
{
id: "customer_id",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically a SEP-24 field, but I assume they are passed in the same manner, so it shouldn't be a problem?
@quietbits WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be fine. We're not strictly checking against "allowed" SEP-9 fields.

@stellar-jenkins
Copy link

@Ifropc Ifropc merged commit bc2f7b0 into master May 1, 2024
2 checks passed
@Ifropc Ifropc deleted the stripe-fields branch May 1, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants