Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/deploy events order #1856

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Fix/deploy events order #1856

merged 2 commits into from
Jan 29, 2025

Conversation

elizabethengelman
Copy link
Contributor

What

Closes #1777

Why

Deploy logs were out of order, printing simulate, submit, sign instead of simulate, sign, submit.

before:

ℹ️ Simulating install transaction…
🌎 Submitting install transaction…
ℹ️ Signing transaction: 95cf4cc442c3120164b9fc9d4cdc8ce338edb0f56ecac7da769f89e645bcaa9a
ℹ️ Using wasm hash 13ec865cd0787ae6c94e44d3cbad2c9a7ae2c546bca4de26d43d923dde2e12fd
ℹ️ Simulating deploy transaction…
🌎 Submitting deploy transaction…
ℹ️ Transaction hash is 4ac86408a0303326efaaaa0087de6738018e39952709ebb9d264a0e9759b054c
🔗 https://stellar.expert/explorer/testnet/tx/4ac86408a0303326efaaaa0087de6738018e39952709ebb9d264a0e9759b054c
ℹ️ Signing transaction: 4ac86408a0303326efaaaa0087de6738018e39952709ebb9d264a0e9759b054c
🔗 https://stellar.expert/explorer/testnet/contract/CDUWDZHBWZX3JKLZ2ZKDIRZWXBEOKG2UOG4HP3IQN4CZ2FBQOVBJAO2C
✅ Deployed!
CDUWDZHBWZX3JKLZ2ZKDIRZWXBEOKG2UOG4HP3IQN4CZ2FBQOVBJAO2C

after:

ℹ️ Simulating install transaction…
ℹ️ Signing transaction: 333c86094ba60d45a90da2c713fab4aa3c25383c19007ec16f373f813cf9c916
🌎 Submitting install transaction…
ℹ️ Using wasm hash 0cc7651ec2be3ec2ab45b5f42aa52478e28ea6ae04e63af4684e2ad88bf56032
ℹ️ Simulating deploy transaction…
ℹ️ Transaction hash is 4ebba74956ae1b9f58c6d038209c6e1977e36d3e2f6a2cc7bba58e63e608e0c5
🔗 https://stellar.expert/explorer/testnet/tx/4ebba74956ae1b9f58c6d038209c6e1977e36d3e2f6a2cc7bba58e63e608e0c5
ℹ️ Signing transaction: 4ebba74956ae1b9f58c6d038209c6e1977e36d3e2f6a2cc7bba58e63e608e0c5
🌎 Submitting deploy transaction…
🔗 https://stellar.expert/explorer/testnet/contract/CBDBUXT3GOFMKLM5KIEETRU32CJNGV5YBALIDYIZ2XX4VYEKLBLGS37Z
✅ Deployed!
**CBDBUXT3GOFMKLM5KIEETRU32CJNGV5YBALIDYIZ2XX4VYEKLBLGS37Z**

Known limitations

N/A

@fnando fnando merged commit 5aa799c into main Jan 29, 2025
25 checks passed
@fnando fnando deleted the fix/deploy-events-order branch January 29, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Deploy outputs events in wrong order in log
2 participants