feat: improve asset parsing to use named keys as issuer #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow users to add public keys with `keys add` so that they can be referenced in commands that need public addresses and contract invoke's that take address arguments.
Add tests using
willemneal
force-pushed
the
feat/asset-parsing
branch
3 times, most recently
from
7dce028 to
2867fc2
Compare
willemneal
requested review from
fnando,
leighmcculloch and
elizabethengelman
willemneal
force-pushed
the
feat/asset-parsing
branch
from
2867fc2 to
bbf8e98
Compare
Co-authored-by: Leigh McCulloch <[email protected]>
- previously we were creating a new keyring entry for each interaction with the keyring - this change will allow us use a mock keyring entry for testing
This will allow for exporting the phrase later
willemneal
force-pushed
the
feat/asset-parsing
branch
from
69fc190 to
f419e1e
Compare
willemneal
force-pushed
the
feat/asset-parsing
branch
from
f419e1e to
3ff015d
Compare
Previously the issuer had to be a fully resolved `xdr::AccountId`, now it can be an `Address`, which then can be resolved. Thus allowing the following: `USDC:circle`
willemneal
force-pushed
the
feat/asset-parsing
branch
from
3ff015d to
4dd01eb
Compare
elizabethengelman
force-pushed
the
feat/asset-parsing
branch
from
97910d6 to
4b955bc
Compare
Co-authored-by: Elizabeth Engelman <[email protected]>
elizabethengelman
added a commit
that referenced
this pull request
Jan 28, 2025
Previously the issuer had to be a fully resolved `xdr::AccountId`, now it can be an `Address`, which then can be resolved. Thus allowing the following: `USDC:circle` --------- Co-authored-by: Leigh McCulloch <[email protected]> Co-authored-by: Elizabeth Engelman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the issuer had to be a fully resolved
xdr::AccountId, now it can be anAddress, which then can be resolved. Thus allowing the following:USDC:circleThis is part 2 of 2 in a stack made with GitButler:
Keytype; allowing public keys to be named keys #1700