Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frame code review #1261

Merged
merged 9 commits into from
Nov 30, 2023
Merged

Frame code review #1261

merged 9 commits into from
Nov 30, 2023

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Nov 29, 2023 •
edited
Loading

Mostly minor stuff:

  • Change errors that are really logic errors into InternalError
  • Notice and error in a case a callback overwrites the local PRNG while it's being established (we don't do this anywhere but in the future someone might accidentally)
  • Factor out some common code
  • Rewrite stuff for legibility (especially the reentry-prevention code which was hard to follow)
  • Fix a couple comments and imports

No functional (or at least observable) change.

@graydon graydon added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit da581fb Nov 30, 2023
10 checks passed
@graydon graydon deleted the graydon-code-review-17 branch November 30, 2023 00:33
@graydon graydon restored the graydon-code-review-17 branch November 30, 2023 21:23
@graydon graydon deleted the graydon-code-review-17 branch November 30, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmkozh dmkozh dmkozh approved these changes

@sisuresh sisuresh Awaiting requested review from sisuresh sisuresh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graydon @dmkozh