-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-calibration on x86 and update cost parameters #1248
Conversation
Thanks @dmkozh and @graydon for the review. I've refreshed the PR again after your comments. Now it should be ready to go again. One thing that's been updated since your last review was the calibration of xdr conversions ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks!
What
Resolves #1246 Also made a minor fix on changing the plain
*
tosaturating_mut
for map charges (mentioned in #1141).This is the first calibration results on x86, previous results were obtained on M1. Overall most of the cost characteristics stay the same, there are some notable changes:
The arithmetics related cost centers have gone up, this includes {U,I}{256, 128} arithmetics, cryptography functions.This was due to the host observation overhead, it has been fixed.InvokeVmFunction
is taking maximum arg size (=32).ValSer
ValSer
has been calibrated using closer-to-worst examplesThe mem-related cost parameters are using analytical inputs (not calibrated), same as before.
raw output
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations