Add libudev-dev and libdbus-1-dev dependencies #662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are these libraries required by any of the software installed in QuickStart? QuickStart doesn't embed the CLI, so shouldn't need these. If an image that builds on QuickStart needs these they should be added to that image. |
Ah, good point! These should be specific to the CLI, so i can close this PR in lieu of the fix directly to the system test repo: stellar/system-test#118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes stellar/system-test#116
Adding libudev-dev and libdbus-1-dev as dependencies - libudev-dev is needed for ledger support (upcoming), and libdbus-1-dev is needed for the crate we are using to support keychain signing.