-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore Endpoints: pages part 1 #805
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
06b446c
All Assets
quietbits 09c8624
Claimable Balances
quietbits c14e892
Effects + refactor endpoint URL template
quietbits fbf1a39
Fee Stats
quietbits daf725d
Ledgers
quietbits b647c95
Offers
quietbits 5ce66cd
Operations
quietbits a1c35fc
Merge branch 'laboratory-v2' of https://github.com/stellar/laboratory…
quietbits 332364b
Fix positiveInt validation when changing routes
quietbits File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import React from "react"; | ||
import { Input, InputProps } from "@stellar/design-system"; | ||
|
||
interface PositiveIntPickerProps extends Omit<InputProps, "fieldSize"> { | ||
id: string; | ||
fieldSize?: "sm" | "md" | "lg"; | ||
labelSuffix?: string | React.ReactNode; | ||
label: string; | ||
value: string; | ||
placeholder?: string; | ||
error: string | undefined; | ||
// eslint-disable-next-line no-unused-vars | ||
onChange: (e: React.ChangeEvent<HTMLInputElement>) => void; | ||
} | ||
|
||
export const PositiveIntPicker = ({ | ||
id, | ||
fieldSize = "md", | ||
labelSuffix, | ||
label, | ||
value, | ||
error, | ||
onChange, | ||
...props | ||
}: PositiveIntPickerProps) => { | ||
return ( | ||
<Input | ||
id={id} | ||
fieldSize={fieldSize} | ||
label={label} | ||
labelSuffix={labelSuffix} | ||
value={value} | ||
error={error} | ||
onChange={onChange} | ||
{...props} | ||
/> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import React from "react"; | ||
import { Input, InputProps } from "@stellar/design-system"; | ||
|
||
interface TextPickerProps extends Omit<InputProps, "fieldSize"> { | ||
id: string; | ||
fieldSize?: "sm" | "md" | "lg"; | ||
labelSuffix?: string | React.ReactNode; | ||
label: string; | ||
value: string; | ||
placeholder?: string; | ||
error: string | undefined; | ||
// eslint-disable-next-line no-unused-vars | ||
onChange: (e: React.ChangeEvent<HTMLInputElement>) => void; | ||
} | ||
|
||
export const TextPicker = ({ | ||
id, | ||
fieldSize = "md", | ||
labelSuffix, | ||
label, | ||
value, | ||
error, | ||
onChange, | ||
...props | ||
}: TextPickerProps) => { | ||
return ( | ||
<Input | ||
id={id} | ||
fieldSize={fieldSize} | ||
label={label} | ||
labelSuffix={labelSuffix} | ||
value={value} | ||
error={error} | ||
onChange={onChange} | ||
{...props} | ||
/> | ||
); | ||
}; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it creates double slashes,
/effects
as an example because of an empty string in between.['', 'liquidity_pools', '', 'effects']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is intentional because a required param is missing. We do the same thing in the current Lab, and I couldn't come up with a better solution. Open to suggestions and improvements!
endpoints-lp-example.webm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the details! I think this is fine :)