Set withMuxing flags dynamically #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is available here: |
accordeiro
approved these changes
Jun 29, 2021
Shaptic
reviewed
Jun 29, 2021
Comment on lines
+543
to
547
| if (isMAddress) { | ||
| account = new Sdk.MuxedAccount.fromAddress(attributes.sourceAccount, sequence); | ||
| } else { | ||
| account = new Sdk.Account(attributes.sourceAccount, sequence); | ||
| } |
There was a problem hiding this comment.
Just musing out loud here: when I initially designed the API, I specifically wanted to avoid people needing if blocks like this... Fundamentally, a muxed account is just another account. The SDK should transparently handle M accounts and G accounts and the user shouldn't have to care. Hopefully in future iterations (see e.g. stellar/js-stellar-base#436) we can remove the need for these kinds of checks.
|
Passed testing w/ sending to both Muxed and regular accounts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.