Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signatures #124

Closed
wants to merge 3 commits into from
Closed

Signatures #124

wants to merge 3 commits into from

Conversation

helmuthb
Copy link

This adds support for signatures of Federation records.

It is based on DKIF - see https://lumenbox.org/dkif-explained/ for some high-level explanation.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 93.238% when pulling 8ca8bb0 on lumenbox:signatures into 2a757e0 on stellar:master.

@morleyzhi
Copy link
Contributor

@helmuthb Sorry for the late response to this PR. We at Stellar are going to put the DKIM SEP through an all-new approval process. In anticipation of that, could you merge in the most recent changes in stellar/js-stellar-base:master? Thanks!

@theaeolianmachine
Copy link

For reference, I left a note on the original issue here: stellar/stellar-protocol#80 (comment)

@abuiles
Copy link
Contributor

abuiles commented Jul 23, 2019

@helmuthb hey thanks for this PR - we discussed this PR internally and we won't be adding this for now. I'll close it and keep track via #212 to get back to it at a later point.

Thanks!

@abuiles abuiles closed this Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants