Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Msvc discover toolchain #8

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

shumpohl
Copy link

Fix #5 ?

I'm not shure if this works correctly in all cases.

@stefanseefeld stefanseefeld force-pushed the develop branch 5 times, most recently from f9fab20 to d0e74b8 Compare November 7, 2018 17:16
@stefanseefeld
Copy link
Owner

I just had a look into your patch. The reason it fails one of the CI builds is that you changed the ordering of the found toolchains using a simple lexicographical comparison. So it happens that, while versions above "10" are all correctly ordered, versions "9.x" end up with higher priority and so is chosen for the test runs.
For some reason that version doesn't work with the tests. (We could arguably remove those versions as "too old", but at the same time this simply highlights the fact that your ordering is wrong. (That was one of the reasons why I preferred explicitly listing the known versions in the registry discovery.)

I may look into ways to rewrite the patch, but feel free to follow up yourself.

@stefanseefeld stefanseefeld force-pushed the develop branch 7 times, most recently from 572eac6 to 05dfeed Compare July 22, 2020 14:44
@stefanseefeld stefanseefeld force-pushed the develop branch 5 times, most recently from 8ef1164 to aa0b035 Compare August 1, 2020 21:39
@stefanseefeld stefanseefeld force-pushed the develop branch 8 times, most recently from 62ed686 to eb6e1a7 Compare December 21, 2020 17:37
@stefanseefeld stefanseefeld force-pushed the develop branch 5 times, most recently from 148a302 to 5b9ae5e Compare December 21, 2020 20:28
@stefanseefeld stefanseefeld force-pushed the develop branch 2 times, most recently from 1fceedf to 0f369a8 Compare February 7, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants