Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add peripheralIsReady support for writes without response #251

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markohara
Copy link

@markohara markohara commented Feb 13, 2021

Fixes #250:

Summary of Problem:

The current solution assumes that write events without a response can automatically be processed however this isn't the case. If we have a large volume of writes without a response the will out grow the Core Bluetooth buffer if they are all processed immediately.

Proposed Solution:

To mitigate against this issue apple have introduce the peripheralIsReady toSendWriteWithoutResponse delegate method. My proposed solution uses this method to determine when the write should be processed. I have introduced a new event type and pass it to the handler when the peripheralIsReady delegate method is called

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write without response assumes we can process the write immediately
1 participant