Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade go to 1.22 #21940

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

ci: upgrade go to 1.22 #21940

wants to merge 1 commit into from

Conversation

siddarthkay
Copy link
Contributor

@siddarthkay siddarthkay commented Jan 16, 2025

Summary

Testing notes

Please test thoroughly.

Areas that may be impacted

  • 1-1 chats
  • public chats
  • group chats
  • account recovery
  • networks
  • mailservers

Platforms

  • Android
  • iOS

status: ready

related: status-im/status-go#6254

@status-im-auto
Copy link
Member

status-im-auto commented Jan 16, 2025

Jenkins Builds

Click to see older builds (12)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 244e83c #1 2025-01-16 13:13:03 ~7 min tests 📄log
✔️ 244e83c #1 2025-01-16 13:16:17 ~10 min android-e2e 🤖apk 📲
✔️ 244e83c #1 2025-01-16 13:17:35 ~11 min android 🤖apk 📲
✔️ 244e83c #1 2025-01-16 13:19:42 ~13 min ios 📱ipa 📲
✔️ f6477ef #2 2025-01-18 06:57:22 ~4 min tests 📄log
✔️ f6477ef #2 2025-01-18 06:59:28 ~6 min android-e2e 🤖apk 📲
✔️ f6477ef #2 2025-01-18 07:00:46 ~8 min android 🤖apk 📲
✔️ f6477ef #2 2025-01-18 07:07:24 ~14 min ios 📱ipa 📲
✔️ 7d38570 #3 2025-01-20 11:33:35 ~5 min tests 📄log
✔️ 7d38570 #3 2025-01-20 11:36:22 ~8 min android-e2e 🤖apk 📲
✔️ 7d38570 #3 2025-01-20 11:36:30 ~8 min android 🤖apk 📲
✔️ 7d38570 #3 2025-01-20 11:43:27 ~15 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
feeac1a #4 2025-01-22 10:37:41 ~26 sec ios 📄log
✔️ feeac1a #4 2025-01-22 10:44:30 ~7 min tests 📄log
✔️ feeac1a #4 2025-01-22 10:48:02 ~10 min android-e2e 🤖apk 📲
✔️ feeac1a #4 2025-01-22 10:48:36 ~11 min android 🤖apk 📲
✔️ feeac1a #5 2025-01-22 10:53:57 ~11 min ios 📱ipa 📲
✔️ 0f21342 #5 2025-01-27 09:42:16 ~5 min tests 📄log
✔️ 0f21342 #5 2025-01-27 09:46:03 ~9 min android 🤖apk 📲
✔️ 0f21342 #5 2025-01-27 09:46:12 ~9 min android-e2e 🤖apk 📲
✔️ 0f21342 #6 2025-01-27 09:51:02 ~14 min ios 📱ipa 📲

@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 8
Failed tests: 1
Expected to fail tests: 0
Passed tests: 7
IDs of failed tests: 702843 

Failed tests (1)

Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 2: Tap on found: Button
    Device 2: Attempt 0 is successful clicking close-activity-center

    Test setup failed: critical/chats/test_public_chat_browsing.py:318: in prepare_devices
        self.home_2.handle_contact_request(self.username_1)
    ../views/home_view.py:388: in handle_contact_request
        chat_element.accept_contact_request()
    ../views/home_view.py:167: in accept_contact_request
        self.handle_cr("accept-contact-request")
    ../views/home_view.py:164: in handle_cr
        ).wait_for_rendering_ended_and_click()
    ../views/base_element.py:154: in wait_for_rendering_ended_and_click
        self.wait_for_visibility_of_element(20)
    ../views/base_element.py:138: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: Button by xpath:`//*[contains(@text, 'shdMXX2GwLkKxY5iVAkS')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    Passed tests (7)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    2. test_wallet_balance_mainnet, id: 740490

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
    Device sessions

    @status-im-auto
    Copy link
    Member

    91% of end-end tests have passed

    Total executed tests: 56
    Failed tests: 3
    Expected to fail tests: 2
    Passed tests: 51
    
    IDs of failed tests: 702786,703202,741054 
    
    IDs of expected to fail tests: 702844,703503 
    

    Failed tests (3)

    Click to expand
  • Rerun failed tests

  • Class TestFallbackMultipleDevice:

    1. test_fallback_add_key_pair, id: 741054

    Device 2: Find `Button` by `xpath`: `//android.view.ViewGroup[contains(@content-desc,'New regular account')]`
    Device 2: Find `Button` by `xpath`: `//android.view.ViewGroup[contains(@content-desc,'Key pair account')]`

    critical/test_fallback.py:203: in test_fallback_add_key_pair
        wallet_2.get_account_element(account_name=key_pair_account_name).click()
    ../views/base_element.py:89: in click
        element = self.find_element()
    ../views/base_element.py:78: in find_element
        raise NoSuchElementException(
     Device 2: Button by xpath: `//android.view.ViewGroup[contains(@content-desc,'Key pair account')]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    Device 2: Getting PN by 'shUFwzMVcE1RVq8yPSgG'
    Device 2: Looking for a message by text: shUFwzMVcE1RVq8yPSgG

    critical/chats/test_public_chat_browsing.py:963: in test_community_mentions_push_notification
        self.errors.verify_no_errors()
    base_test_case.py:176: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Push notification with the mention was not received by admin
    E    Can not edit a message with a mention
    



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202

    Device 1: Find EmojisNumber by xpath: //*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView[2]
    Device 1: Find EmojisNumber by xpath: //*[starts-with(@text,'This is a test message to check some reactions.')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView[2]

    critical/chats/test_group_chat.py:131: in test_group_chat_reactions
        self.loop.run_until_complete(run_in_parallel((
    /usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
        return future.result()
    __init__.py:38: in run_in_parallel
        returns.append(await k)
    /usr/lib/python3.10/concurrent/futures/thread.py:58: in run
        result = self.fn(*self.args, **self.kwargs)
    critical/chats/test_group_chat.py:127: in _check_reactions_count
        chat_element.emojis_below_message(emoji="thumbs-up").wait_for_element_text(2)
    ../views/base_element.py:181: in wait_for_element_text
        self.driver.fail(message if message else "`%s` is not equal to expected `%s` in %s sec" % (
    base_test_case.py:154: in fail
        pytest.fail('Device %s: %s' % (self.number, text))
     Device 1: `1` is not equal to expected `2` in 30 sec
    



    Device sessions

    Expected to fail tests (2)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503

    Device 1: Find Button by accessibility id: communities-home-discover-card
    Device 1: Tap on found: Button

    critical/chats/test_public_chat_browsing.py:261: in test_community_discovery
        self.home.community_card_item.wait_for_elements(seconds=120)
    ../views/base_element.py:129: in wait_for_elements
        raise TimeoutException(
     Device 1:  BaseElement by accessibility id:`community-card-item` is not found on the screen after wait_for_elements 
    

    [[Might fail if the Discover curation dapp is too slow to load > 2 mins]]

    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

    Device 2: Find EmojisNumber by xpath: //*[starts-with(@text,'https://m.youtube.com/watch?v=Je7yErjEVt4')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-4']/android.widget.TextView[2]
    Device 2: Element EmojisNumber text is equal to 1

    critical/chats/test_public_chat_browsing.py:650: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable
        self.errors.verify_no_errors()
    base_test_case.py:176: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     No preview is loaded for url https://youtu.be/Je7yErjEVt4
    E    No preview is loaded for url https://www.youtube.com/watch?v=XN-SVmuJH2g&list=PLbrz7IuP1hrgNtYe9g6YHwHO6F3OqNMao
    E    No preview is loaded for url https://m.youtube.com/watch?v=Je7yErjEVt4 
    

    [[Youtube links preview is not loaded on LambdaTest emulators, needs investigation]]

    Device sessions

    Passed tests (51)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    3. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    4. test_community_unread_messages_badge, id: 702841
    Device sessions

    5. test_community_message_delete, id: 702839
    Device sessions

    6. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    7. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    8. test_community_one_image_send_reply, id: 702859
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_several_images_send_reply, id: 703194
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    2. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    3. test_add_contact_field_validation, id: 702777
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230
    2. test_wallet_send_eth, id: 727229

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    2. test_wallet_balance_mainnet, id: 740490

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    4. test_community_undo_delete_message, id: 702869
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_offline_pn, id: 702808
    Device sessions

    3. test_group_chat_pin_messages, id: 702732
    Device sessions

    4. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    5. test_group_chat_mute_chat, id: 703495
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_leave, id: 702845
    Device sessions

    2. test_community_markdown_support, id: 702809
    Device sessions

    3. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    4. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestFallbackMultipleDevice:

    1. test_fallback_sync_with_error, id: 740220
    2. test_fallback_with_correct_seed_phrase, id: 740221
    3. test_fallback_validate_seed_phrase, id: 740222

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links_profile, id: 702775
    Device sessions

    3. test_deep_links_communities, id: 739307
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_edit_message, id: 702855
    Device sessions

    2. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    4. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    5. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    6. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    7. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    8. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    @churik
    Copy link
    Member

    churik commented Jan 20, 2025

    @siddarthkay what can be affected area / possible regression?
    To retest the whole app requires around 3 days of several QAs, so would be mice to narrow it down.

    @siddarthkay
    Copy link
    Contributor Author

    siddarthkay commented Jan 20, 2025

    @churik: from past experience, the previous go upgrade had impacted store node communication.
    But really it could be anything where status-go is involved.
    This PR essentially uses newer go version (1.22) to compile status-go.

    I've updated the PR description from template on possible impacted areas.

    @status-im-auto
    Copy link
    Member

    83% of end-end tests have passed

    Total executed tests: 6
    Failed tests: 1
    Expected to fail tests: 0
    Passed tests: 5
    
    IDs of failed tests: 702786 
    

    Failed tests (1)

    Click to expand
  • Rerun failed tests

  • Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_mentions_push_notification, id: 702786

    Device 2: Getting PN by 'shNJe4G6Y7nMihcNz6Ja'
    Device 2: Looking for a message by text: shNJe4G6Y7nMihcNz6Ja

    critical/chats/test_public_chat_browsing.py:966: in test_community_mentions_push_notification
        self.errors.verify_no_errors()
    base_test_case.py:176: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Edited message is not shown correctly for the (receiver) admin
    



    Device sessions

    Passed tests (5)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_reactions, id: 703202
    Device sessions

    Class TestFallbackMultipleDevice:

    1. test_fallback_add_key_pair, id: 741054
    2. test_fallback_sync_with_error, id: 740220
    3. test_fallback_with_correct_seed_phrase, id: 740221
    4. test_fallback_validate_seed_phrase, id: 740222

    @Horupa-Olena
    Copy link

    Horupa-Olena commented Jan 24, 2025

    @siddarthkay Hi! Thanks for your PR!
    All declared areas of the PR have been tested. No critical bugs were identified during the testing.

    However, it was observed that switching from Wi-Fi to a mobile network caused message delays of 1-2 minutes in 1-1 chats, group chats, and communities.
    This issue was previously fixed and verified within this PR, and it currently works without delays in the nightly build (except group chat), unlike in the current PR.

    Additionally, it was noticed a few times that the icon for certain contacts disappeared (showing a cross), but it later reappeared.
    Images (logos and covers) in communities also failed to load randomly, although a re-login usually resolved the issue.
    photo_2025-01-24_12-08-26
    photo_2025-01-24_12-08-24
    photo_2025-01-24_12-08-22

    Logs reciever:
    log_recieve.zip
    Logs sender:
    https://drive.google.com/file/d/1_aWiVb6NcOYbigog_HCKJ9SdWuVQOC3G/view?usp=sharing

    Please let me know if any additional information is needed.
    cc @chaitanyaprem

    @churik
    Copy link
    Member

    churik commented Jan 24, 2025

    @Horupa-Olena with a cross icons I have seen it in nightly too;

    as for delay when switching from wi-Fi to cellular, it shoudl be checked, may be @chaitanyaprem have an idea might this PR affect his fix?

    @chaitanyaprem
    Copy link
    Contributor

    as for delay when switching from wi-Fi to cellular, it shoudl be checked, may be @chaitanyaprem have an idea might this PR affect his fix?

    Nothing in this PR should affect this. But i am wondering if could be due to store node issue.

    @Horupa-Olena can i get geth.log for receiver and timestamps for message sent and text as well?

    @Horupa-Olena
    Copy link

    @chaitanyaprem I couldn't obtain this log because the file was too large and didn't attach when reporting the issue via email.

    I tried throughout the day to reproduce this issue (to attempt getting the geth.log), but messages started arriving quickly without delays.
    Since, according to you, this PR couldn't have affected your changes in any way, could it be some temporary glitch caused by other reasons?

    @chaitanyaprem
    Copy link
    Contributor

    chaitanyaprem commented Jan 25, 2025

    @chaitanyaprem I couldn't obtain this log because the file was too large and didn't attach when reporting the issue via email.

    I tried throughout the day to reproduce this issue (to attempt getting the geth.log), but messages started arriving quickly without delays.
    Since, according to you, this PR couldn't have affected your changes in any way, could it be some temporary glitch caused by other reasons?

    if it is not reproducible, then it could be due to temporary glitch with store nodes or some kind of a corner scenario which doesn't get hit always.

    @churik
    Copy link
    Member

    churik commented Jan 27, 2025

    @Horupa-Olena in this case we can safely move PR to "Merge", thank you!

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Status: MERGE
    Development

    Successfully merging this pull request may close these issues.

    6 participants