-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix_: simplify version used in go:generate #6276
Conversation
Jenkins Builds
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6276 +/- ##
===========================================
+ Coverage 61.81% 61.85% +0.04%
===========================================
Files 843 843
Lines 111286 111286
===========================================
+ Hits 68789 68838 +49
+ Misses 34521 34483 -38
+ Partials 7976 7965 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@siddarthkay, I would fix the |
Summary
This PR simplifies version generation.
Mobile
nix
derivation forstatus-go
is unable to find this script since its filtered out via ourmkfilter
.https://github.com/status-im/status-mobile/blob/develop/nix/status-go/source.nix#L31
Otherwise we get errors like :