Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_: simplify version used in go:generate #6276

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

siddarthkay
Copy link
Contributor

Summary

This PR simplifies version generation.
Mobile nix derivation for status-go is unable to find this script since its filtered out via our mkfilter.
https://github.com/status-im/status-mobile/blob/develop/nix/status-go/source.nix#L31

Otherwise we get errors like :

sh: line 1: ../../_assets/scripts/version.sh: cannot execute: required file not found

@siddarthkay siddarthkay self-assigned this Jan 23, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Jan 23, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ bbeb707 #1 2025-01-23 10:46:20 ~4 min ios 📦zip
✔️ bbeb707 #1 2025-01-23 10:46:27 ~4 min macos 📦zip
✔️ bbeb707 #1 2025-01-23 10:47:11 ~5 min macos 📦zip
✔️ bbeb707 #1 2025-01-23 10:47:21 ~5 min linux 📦zip
✔️ bbeb707 #1 2025-01-23 10:47:30 ~5 min windows 📦zip
✔️ bbeb707 #1 2025-01-23 10:48:41 ~6 min android 📦aar
✔️ bbeb707 #1 2025-01-23 10:49:17 ~7 min tests-rpc 📄log
✔️ bbeb707 #1 2025-01-23 11:12:52 ~30 min tests 📄log

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.85%. Comparing base (5240da6) to head (bbeb707).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6276      +/-   ##
===========================================
+ Coverage    61.81%   61.85%   +0.04%     
===========================================
  Files          843      843              
  Lines       111286   111286              
===========================================
+ Hits         68789    68838      +49     
+ Misses       34521    34483      -38     
+ Partials      7976     7965      -11     
Flag Coverage Δ
functional 21.65% <ø> (+0.09%) ⬆️
unit 60.33% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/version/version.go 100.00% <ø> (ø)

... and 30 files with indirect coverage changes

@siddarthkay siddarthkay merged commit 06d2419 into develop Jan 24, 2025
19 checks passed
@siddarthkay siddarthkay deleted the fix-path-to-version-sh branch January 24, 2025 17:00
@yakimant
Copy link
Member

yakimant commented Feb 3, 2025

@siddarthkay, I would fix the mkfilter instead of duplicating the code.
Next time you want to change it - you'll need to do it in 2 places.
I don't think it simplifies version generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants