chore(wallet)_: community deployment related types moved to wallet requests package #6261
+2,206
−1,636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (40)
|
This was referenced Jan 16, 2025
saledjenic
requested review from
a team,
iurimatias,
osmaczko,
Cuteivist,
Khushboo-dev-cpp,
alaibe and
jrainville
and removed request for
a team
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router-pre-step-1
branch
from
1d65c1d to
dd8d64c
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (23.20%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6261 +/- ##
===========================================
- Coverage 61.91% 61.75% -0.17%
===========================================
Files 843 849 +6
Lines 111287 111406 +119
===========================================
- Hits 68903 68795 -108
- Misses 34449 34605 +156
- Partials 7935 8006 +71
Flags with carried forward coverage won't be shown. Click here to find out more.
|
osmaczko
approved these changes
Jan 20, 2025
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router-pre-step-1
branch
from
dd8d64c to
bd9e28c
Compare
dlipicar
reviewed
Jan 23, 2025
|
|
||
| var ( | ||
| ErrEmptyCollectibleName = &errors.ErrorResponse{Code: errors.ErrorCode("WRRC-001"), Details: "empty collectible name"} | ||
| ErrEmptyCollectibleSymbol = &errors.ErrorResponse{Code: errors.ErrorCode("WRRC-002"), Details: "empty collectible symbol"} |
There was a problem hiding this comment.
Do these endpoints only apply to Collectibles? I though they were used for assets as well (since there's a Decimals member in the struct)
There was a problem hiding this comment.
@dlipicar yes, that's the check we had, look here: https://github.com/status-im/status-go/blob/develop/services/communitytokens/api.go#L87-L103
applicable to deployment parameters for assets and collectibles.
There was a problem hiding this comment.
I removed the "collectible" word from the error and made it that way more general.
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router-pre-step-1
branch
from
bd9e28c to
3411914
Compare
igor-sirotin
approved these changes
Jan 27, 2025
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router-pre-step-1
branch
from
3411914 to
1cd6410
Compare
dlipicar
approved these changes
Jan 29, 2025
|
Looks like you have BREAKING CHANGES in your PR. Check-list
|
osmaczko
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Looks logical to move this stuff to the wallet, thanks 👍
I would be very careful, though—could you please ask QAs to perform full regression testing for community token management (minting owner token, transferring ownership, etc.) on corresponding desktop PR before merging this?
| @@ -270,7 +269,6 @@ type AssetContractData struct { | |||
|
|
|||
| type CommunityTokensServiceInterface interface { | |||
| GetCollectibleContractData(chainID uint64, contractAddress string) (*CollectibleContractData, error) | |||
| SetSignerPubKey(ctx context.Context, chainID uint64, contractAddress string, txArgs wallettypes.SendTxArgs, password string, newSignerPubKey string) (string, error) | |||
There was a problem hiding this comment.
I couldn't find how the signer pubkey is set after the changes?
There was a problem hiding this comment.
@osmaczko it's not used as an explicit API endpoint anymore but goes over the router now, because at the end that's just a tx.
@osmaczko QAs have already tested the desktop PR status-im/status-desktop#17010 |
…quests package `DeploymentParameters` and `DeploymentDetails` types moved from `communitytokens` package to `requests` of the wallet service.
…outer - new file `contracts/community-tokens/contracts.go` added to unify contracts creation - the following community related path processors added: - `CommunityBurnProcessor` - `CommunityDeployAssetsProcessor` - `CommunityDeployCollectiblesProcessor` - `CommunityDeployOwnerTokenProcessor` - `CommunityMintTokensProcessor` - `CommunityRemoteBurnProcessor` - `CommunitySetSignerPubKeyProcessor` - `SendType` extended with appropriate options - added endpoints to duplicated `communitytokens` api: - `StoreDeployedCollectibles` - `StoreDeployedOwnerToken` - `StoreDeployedAssets` - removed endpoints from duplicated `communitytokens` api: - `DeployCollectibles` - `DeployOwnerToken` - `ReTrackOwnerTokenDeploymentTransaction` - `DeployAssets` - `DeployCollectiblesEstimate` - `DeployAssetsEstimate` - `DeployOwnerTokenEstimate` - `EstimateMintTokens` - `EstimateRemoteBurn` - `EstimateBurn` - `EstimateSetSignerPubKey` - `NewOwnerTokenInstance` - `NewCommunityTokenDeployerInstance` - `NewCommunityOwnerTokenRegistryInstance` - `NewCollectiblesInstance` - `NewAssetsInstance` - `MintTokens` - `RemoteBurn` - `GetCollectiblesContractInstance` - `GetAssetContractInstance` - `Burn` - `SetSignerPubKey` - `Path` type extended with new property: - `UsedContractAddress` - an address of the contract that will be used for the transaction
This is a breaking change which removes `communitytokens` package. This commit removes old `communitytokens` package, cause previously added `communitytokensv2` package, which is in use now, will be renamed to `communitytokens` in next commit.
This is a breaking change which renames `communitytokensv2` package to `communitytokens`.
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router-pre-step-1
branch
from
6bc6fdf to
3575b7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeploymentParametersandDeploymentDetailstypes moved fromcommunitytokenspackage torequestsof the wallet service.This is the first step in moving community-related transactions from
communitytokenstowalletservice.Related PRs: