Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] lets not track changes in vendor at all #4164

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

siddarthkay
Copy link
Contributor

WIP do not review

This PR is an attempt to not track vendor folder in git.
The vendor folder will still exist locally and can be generated locally via make vendor

status: WIP

@siddarthkay siddarthkay self-assigned this Oct 17, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Oct 17, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
a112a90 #1 2023-10-17 14:01:27 ~24 sec android 📄log
a112a90 #1 2023-10-17 14:01:29 ~27 sec ios 📄log
✔️ a112a90 #1 2023-10-17 14:04:10 ~3 min linux 📦zip
✖️ a112a90 #1 2023-10-17 14:33:34 ~32 min tests 📄log

@ghost
Copy link

ghost commented Oct 17, 2023

vendor/github.com/francoispqt/gojay/Gopkg.lock and vendor/github.com/libp2p/go-cidranger/Gopkg.lock changed. Pinging @corpetty

Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep mind that this change will most probably also require changes to how status-go is built by Nix in status-mobile.

@jakubgs
Copy link
Member

jakubgs commented Oct 17, 2023

As far as I can tell the main problem with this is that we'd have to switch the status-mobile derivation for status-go from using buildGoPackage to use buildGoModule, which in turn requires the vendorSha256 parameter. This is problematic because it would have to be updated every time status-go version is updated, as it is in go-waku for example:

          # FIXME: This needs to be manually changed when updating modules.
          vendorSha256 = "sha256-4xChSKAkwwrFp5/ZMnhtvsR4drVfw1cLE3YXwVHeW0A=";

https://github.com/status-im/go-waku/blob/bfee9964f65d6169165ac7d6335541c42f134f6b/flake.nix#L31-L32

I even made a thread on Nix Discourse about this:

@siddarthkay
Copy link
Contributor Author

latest is https://discourse.nixos.org/t/how-should-i-build-a-go-package-from-local-source/19490/12
converting this PR to draft till we figure out a proper way forward.

@siddarthkay siddarthkay marked this pull request as draft December 28, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants