Publish image and contact code when joining community #4011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (8)
|
cammellos
force-pushed
the
feature/contact-code-when-community
branch
from
0a47d06 to
c7dec38
Compare
cammellos
force-pushed
the
feature/contact-code-when-community
branch
from
c7dec38 to
acbea6f
Compare
cammellos
force-pushed
the
feature/contact-code-when-community
branch
from
acbea6f to
cddfe16
Compare
osmaczko
reviewed
Oct 25, 2023
| @@ -791,6 +791,11 @@ func (m *Messenger) joinCommunity(ctx context.Context, communityID types.HexByte | |||
| if err = m.subscribeToCommunityShard(community.ID(), community.Shard()); err != nil { | |||
| return nil, err | |||
| } | |||
|
|
|||
| if err = m.publishContactCodeInCommunity(community); err != nil { | |||
There was a problem hiding this comment.
Contact code is already triggered few lines below:
status-go/protocol/messenger_communities.go
Line 818 in cddfe16
🤔
There was a problem hiding this comment.
It was already addressed in this PR: #2745
publishIdentityImageis now triggered each time user joins a new community, this is to ensure other community members got updated with user details immediately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We publish a contact code as soon as we join a community, so that other users in the community can retrieve it