Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dogfooding raw message by type metric #17126

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/backend/accounts.nim
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,8 @@ proc openedAccounts*(path: string): RpcResponse[JsonNode] =
"logDir": "", # Empty value defaults to `dataDir`
"logLevel": status_const.getStatusGoLogLevel(),
"apiLoggingEnabled": status_const.API_LOGGING,
"wakuMetricsEnabled": status_const.WAKU_METRICS_ENABLED,
"wakuMetricsPort": status_const.WAKU_METRICS_PORT
}
# Do not remove the sleep 700
# This sleep prevents a crash on intel MacOS
Expand Down
2 changes: 2 additions & 0 deletions src/constants.nim
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ let
SENTRY_DSN_STATUS_GO* = BUILD_SENTRY_DSN_STATUS_GO
SENTRY_DSN_STATUS_GO_DESKTOP* = BUILD_SENTRY_DSN_STATUS_DESKTOP
API_LOGGING* = desktopConfig.apiLogging
WAKU_METRICS_ENABLED* = desktopConfig.wakuMetricsEnabled
WAKU_METRICS_PORT* = desktopConfig.wakuMetricsPort

proc hasLogLevelOption*(): bool =
for p in cliParams:
Expand Down
10 changes: 10 additions & 0 deletions src/env_cli_vars.nim
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,16 @@ type StatusDesktopConfig = object
desc: "Enables status-go API logging"
name: $BASE_NAME_API_LOGGING
abbr: "api-logging" .}: bool
wakuMetricsEnabled* {.
defaultValue: false
desc: "Enables waku metrics and starts prometheus"
name: "WAKU_METRICS"
abbr: "waku-metrics" .}: bool
wakuMetricsPort* {.
defaultValue: 9305
desc: "Sets port for prometheus metrics"
name: "WAKU_METRICS_PORT"
abbr: "waku-metrics-port" .}: int

# On macOS the first time when a user gets the "App downloaded from the
# internet" warning, and clicks the Open button, the OS passes a unique process
Expand Down