fix(settings): fix setNimbusProxyConfigEnabled in the settings

fixes #12918 (part 3/4)

src/app/modules/main/profile_section/advanced/controller.nim

@@ -122,7 +122,7 @@ proc isNimbusProxyEnabled*(self: Controller): bool =
 proc toggleNimbusProxy*(self: Controller) =
   let enabled = self.nodeConfigurationService.isNimbusProxyEnabled()
 
-  if(not self.nodeConfigurationService.setNimbusProxyConfig(not enabled)):
+  if not self.nodeConfigurationService.setNimbusProxyConfigEnabled(not enabled):
     error "an error occurred, we couldn't toggle nimbus proxy"
     return
 

src/app_service/service/node_configuration/service.nim

@@ -233,10 +233,11 @@ proc getNimbusProxyConfig(self: Service): bool =
 proc isNimbusProxyEnabled*(self: Service): bool =
   return self.getNimbusProxyConfig()
 
-proc setNimbusProxyConfig*(self: Service, value: bool): bool =
-  var newConfiguration = self.configuration
-  newConfiguration.NimbusProxyConfig.Enabled = value
-  return self.saveConfiguration(newConfiguration)
+proc setNimbusProxyConfigEnabled*(self: Service, enabled: bool): bool =
+  # FIXME: call status-go API to update NodeConfig
+  # when this is merged https://github.com/status-im/status-go/pull/4254
+  self.configuration.NimbusProxyConfig.Enabled = enabled
+  return true
 
 proc isLightClient*(self: Service): bool =
    return self.configuration.WakuV2Config.LightClient

src/backend/node_config.nim

@@ -57,4 +57,4 @@ proc setLightClient*(enabled: bool): RpcResponse[JsonNode] =
   let payload = %*[{
     "enabled": enabled
   }]
-  result = callRPCMethod("setLightClient", payload)
+  result = callRPCMethod("setLightClient", payload)