Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting skipNetworkIdleEvent #28

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

imilchev
Copy link

@imilchev imilchev commented Dec 19, 2024

Summary

This PR fixes/implements the following features

  • Allow setting skipNetworkIdleEvent

Explain the motivation for making this change. What existing problem does the pull request solve?

By default, the value of skipNetworkIdleEvent is true. In the existing API we only have a way to explicitly set the value to true. This means we actually have no way to set this to false

Test plan (required)

Demonstrate the code is solid. Example: The exact commands you ran and their output.

I believe the change is simple enough to not require extra testing

Closing issues

Fixes #

Checklist

  • Have you followed the guidelines in our CONTRIBUTING guide?
  • Have you lint your code locally prior to submission (make lint)?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally (make tests)?
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code

@starwalkn
Copy link
Owner

Please change the signature of an existing method so that it accepts an argument of bool type to avoid creating duplicates. Leave the name unchanged.

@imilchev
Copy link
Author

sure, I can do that but it will be a breaking change for users

@imilchev
Copy link
Author

I adjusted the PR

@starwalkn starwalkn self-requested a review December 19, 2024 21:12
@starwalkn starwalkn merged commit 9aedcc1 into starwalkn:master Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants