Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes/implements the following features
skipNetworkIdleEvent
Explain the motivation for making this change. What existing problem does the pull request solve?
By default, the value of
skipNetworkIdleEvent
istrue
. In the existing API we only have a way to explicitly set the value totrue
. This means we actually have no way to set this tofalse
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output.
I believe the change is simple enough to not require extra testing
Closing issues
Fixes #
Checklist
make lint
)?make tests
)?