Rc2.3 calib betafix #852
Merged
Rc2.3 calib betafix #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not want to take .values. Beginning of addressing #846.
* Separated combining replicates from bootstrapping. The default combine_reps is now None, which bypasses combining replicates. * Now taking the mean across replicates instead of the sum. This change is important if using the `include_fn` and some replicates are rejected, resulting in a varying number of replicates across input parameter sets. The mean is the right operation here, not the sum. * Fix a bug that was causing check_fit to do 4 replicates even when the user did not ask for replicates. * Re-enabling calibration tests.
…lace +1) method to avoid bias. A user could manually add 1 to x and n if they want the prior (1,1) instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
include_fnand some replicates are rejected, resulting in a varying number of replicates across input parameter sets. The mean is the right operation here, not the sum.Avoids converting ss.beta to "values" before multiplying computing transmission, partly addressing #846.
Checklist