Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixing pool updates #848

Merged
merged 6 commits into from
Feb 14, 2025
Merged

Mixing pool updates #848

merged 6 commits into from
Feb 14, 2025

Conversation

RomeshA
Copy link
Contributor

@RomeshA RomeshA commented Jan 29, 2025

Description

This PR adjusts mixing pools slightly to make them behave more interchangeably with networks. In particular, we encountered two issues

  • Mixing pool infections were previously computed in the step() method, which runs prior to interventions unlike network-based transmission which occurs after interventions
  • We had additional logic in our infect() method to adjust rel_sus and rel_trans prior to transmission, but this method was not used for mixing pool infections

These changes shift execution of mixing pool infections into Infection.infect() so that they occur in the same place and in a similar way to network based infections.

Checklist

  • Code commented & docstrings added
  • New tests were needed and have been added
  • A new version number was needed & changelog has been updated
  • A new PyPI version needs to be released

@cliffckerr cliffckerr changed the base branch from main to rc2.3 February 14, 2025 04:43
@cliffckerr cliffckerr merged commit 1755469 into rc2.3 Feb 14, 2025
0 of 2 checks passed
@cliffckerr cliffckerr deleted the mixing-pool-updates branch February 14, 2025 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants