Time experiments #847
Draft
Time experiments #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress branch for brainstorming ways to make working with durations/rates a bit more automatic and safer by reducing reliance on the parent dt.
API examples are currently in
starsim/time.py(that file can be run directly as a demo)Still in progress, the
Timeclass with the time arrays and dists still need a little work before the models can be run. The current plan would be forDistobjects to have pars that retain their original units, and then to internally do conversion to their parent dt and cache the bare values for use withrvs()(so they would still return bare values for consumption by their parent module, for performance reasons. It seems like it would not be practical forDistobjects to return arrays of dur/rate/other objects). But other modules could check the dist object to access the parameter values with full duration information without having to also convert using the correct parent dt)