Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opened issue to rustc #1006

Merged
merged 1 commit into from
Feb 10, 2025
Merged

opened issue to rustc #1006

merged 1 commit into from
Feb 10, 2025

Conversation

Alon-Ti
Copy link
Contributor

@Alon-Ti Alon-Ti commented Feb 10, 2025

Formal column_size in expression evaluator.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

Alon-Ti commented Feb 10, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (a194fad) to head (d273df7).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1006      +/-   ##
==========================================
- Coverage   92.92%   92.90%   -0.03%     
==========================================
  Files         105      105              
  Lines       14243    14241       -2     
  Branches    14243    14241       -2     
==========================================
- Hits        13236    13230       -6     
- Misses        927      931       +4     
  Partials       80       80              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alon-Ti Alon-Ti force-pushed the alont/formal-log-size branch from 79ecce4 to d273df7 Compare February 10, 2025 10:54
@Alon-Ti Alon-Ti marked this pull request as ready for review February 10, 2025 10:54
@Alon-Ti Alon-Ti requested a review from andrewmilson February 10, 2025 10:55
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: d273df7 Previous: 394f839 Ratio
iffts/simd ifft/21 6564024 ns/iter (± 160371) 3131518 ns/iter (± 173718) 2.10
iffts/simd ifft/22 13396723 ns/iter (± 460493) 6272224 ns/iter (± 205833) 2.14
iffts/simd ifft/23 29994900 ns/iter (± 698048) 14961930 ns/iter (± 137907) 2.00
iffts/simd ifft/26 260880738 ns/iter (± 4928692) 130127722 ns/iter (± 2059058) 2.00
iffts/simd ifft/27 561814041 ns/iter (± 31590627) 269533636 ns/iter (± 2406787) 2.08
merkle throughput/simd merkle 30814792 ns/iter (± 394929) 13123349 ns/iter (± 484950) 2.35

This comment was automatically generated by workflow using github-action-benchmark.

CC: @shaharsamocha7

Copy link
Contributor

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @alon-f)

@Alon-Ti Alon-Ti merged commit 9f7fe0f into dev Feb 10, 2025
45 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants